Changes to Mobile/region.properties

RESOLVED WONTFIX

Status

Mozilla Localizations
es-ES / Spanish
RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: rickiees, Assigned: rickiees)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8436314 [details] [diff] [review]
Productization changes in mobile/chrome/region.properties

Proposed es-ES changes to mobile/region.properties following this changeset:

http://hg.mozilla.org/mozilla-central/rev/6753ebfdf4b4#l17.1
(Assignee)

Updated

4 years ago
Attachment #8436314 - Flags: review?(stas)
Comment on attachment 8436314 [details] [diff] [review]
Productization changes in mobile/chrome/region.properties

Review of attachment 8436314 [details] [diff] [review]:
-----------------------------------------------------------------

Stas is not doing productization reviews anymore. ;-)

About Mobile and suggested sites, we still need to figure out how to manage them. 
I'll send out a message to dev-l10n as soon as I have more info. For now, let's keep this bug open.
Attachment #8436314 - Flags: review?(stas)
(Assignee)

Comment 2

4 years ago
(In reply to Francesco Lodolo [:flod] from comment #1)
> Stas is not doing productization reviews anymore. ;-)


Sorry, I was a bit lost and searched for info at MDN, and I found this:

https://developer.mozilla.org/en-US/docs/Productization_patches#Review.2C_commit.2C_.26_land

(and go up just a couple of lines).


> About Mobile and suggested sites, we still need to figure out how to manage
> them. 
> I'll send out a message to dev-l10n as soon as I have more info. For now,
> let's keep this bug open.


...So should I land the en-US version for now, or wait until your post to m.d.l10n? I was trying to get es-ES green before channel migration, which IIRC, will happen next Monday. :-?
(In reply to Ricardo Palomares from comment #2)
> Sorry, I was a bit lost and searched for info at MDN, and I found this:
> https://developer.mozilla.org/en-US/docs/Productization_patches#Review.
> 2C_commit.2C_.26_land

Thanks, I'll update that page.

> ...So should I land the en-US version for now, or wait until your post to
> m.d.l10n? I was trying to get es-ES green before channel migration, which
> IIRC, will happen next Monday. :-?

Your build should is already green, those keys are whitelisted.
https://l10n.mozilla.org/teams/es-ES#fennec

Also, these values, unlikely other elements in region.properties, fall back to en-US values if missing. It's not ideal (description and urls need to be updated), but at least they're not missing.
(Assignee)

Comment 4

3 years ago
flod, I see this didn't land in es-ES. Is something I should do, or can I close this bug as WONTFIX?
Flags: needinfo?(francesco.lodolo)
It's a wontfix at this point, we never started accepting these keys from localization.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(francesco.lodolo)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.