Closed Bug 1022167 Opened 6 years ago Closed 6 years ago
Ensure fence delivery for non-tiled thebes layer in b2g process gonk
1.88 MB, video/mp4
2.22 MB, video/mp4
2.82 KB, patch
|Details | Diff | Splinter Review|
1.37 MB, video/mp4
gecko deliver fence object by best effort for TiledContentClient. There is a cases that it is not enough. We need to ensure fence delivery for TiledContentClient. Basics of fence delivery ensuring is already implemented by Bug 1006957. I am going to use it. On later master nexus-5, this problem could be easily produced the the following STR. - Start Setting app - move "Developer" ->"Debugging via USB ADB only" - On pop up window tousch "Disabled", ADB only and "ADB and DevTools" repeatedly until the problem happens. If the problem does not happen, restart the Settings app.
On Bug 1006957, fence delivery ensuring is already implemented for un-tiled thebes layer, canvas layer and Image layer.
blocking-b2g: --- → 1.4?
Nominate to b2g-v1.4. It is very bad user experience.
I saw the problem also on QRD8X26.
By the investigation the problem in comment 0 and Fence delivery for TiledLayer is independent problem. The problem happens on non-tiled thebes layer in chrome process(b2g). I am going to split "Ensure Fence delivery for TiledLayer" to a new bug.
Summary: Ensure fence delivery for TiledContentClient on gonk → Ensure fence delivery for non-tiled thebes layer in b2g process gonk
(In reply to Sotaro Ikeda [:sotaro] from comment #6) > This is a regression of Bug 1006957. I already locally confirmed the fix on nexus-5.
I confirmed the fix on master nexut-5.
Attachment #8442121 - Flags: review?(nical.bugzilla)
Re-nominate to b2g-v1.4. It becomes clear that the problem is regression of Bug 1006957. And the problem happens not only on nexus-5 and also on qcom's qrd device. By the problem, UIs that exist in chrome process(b2g process) could cause the problem like attachment 8436331 [details]. Confirmation window UI is one example of the cases.
Can you please attach a screen shot? Given that its a regression and reproducible on several devices I'm keen to understand/ see the user impact.
I was very difficult to take a screen shot and failed to get it. Instead, I attached a movie of QRD8x26. The touched item of left most area becomes totally transparent.
Comment on attachment 8442121 [details] [diff] [review] patch - Ensure fence delivery of thebes layer in b2g process Review of attachment 8442121 [details] [diff] [review]: ----------------------------------------------------------------- gfxPlatform::UsesOffMainThreadCompositing() will always return true in these code paths, r=me if you remove it from the if()s.
Attachment #8442121 - Flags: review?(nical.bugzilla) → review+
Apply the comment. Carry "r=nical".
Attachment #8442121 - Attachment is obsolete: true
There is significant flicker but I want to know if this happens only on the Settings App or other Apps as well?
(In reply to Preeti Raghunath(:Preeti) from comment #15) > There is significant flicker but I want to know if this happens only on the > Settings App or other Apps as well? The flicker could happen also another app that uses chrome(b2g process) side UI.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Test team, Please test the patch on master. Would like to take in 1.4 so waiting for analysis.
No-jun, do you mind taking a look at this patch fix on the next master build, and see if this patch 1) is fixed, and 2) has any repercussions anywhere else? your analysis will help triage decide if this patch is low risk for 1.4 uplift. Thanks!
Sotaro, I flashed the local build of gecko into my flame device, and although the original issue is no longer reproducible, i see the exact issue of Bug 1023506 happening again. (the str is same, but more frequent once the orientation change is made) Do you think they are related or would it be caused by something else?
Flags: needinfo?(npark) → needinfo?(sotaro.ikeda.g)
(In reply to No-Jun Park [:njpark] from comment #20) > Sotaro, I flashed the local build of gecko into my flame device, and > although the original issue is no longer reproducible, i see the exact issue > of Bug 1023506 happening again. (the str is same, but more frequent once > the orientation change is made) Do you think they are related or would it > be caused by something else? I did not saw the problem on flame device. The problem happens more large display device. It happened on qrd8X26 and nexus-5. I do not have a madai device, it also seems to have large display, the problem could happen on it, I think.
> i see the exact issue of Bug 1023506 happening again. Bug 1023506 seems different problem. It seems gallery app's problem.
Not a critical regression, so not blocking.
blocking-b2g: 1.4? → backlog
It fixes Bug 1033588. Please land the patch in v2.0 branch as well.
blocking-b2g: backlog → 2.0?
Cannot reproduce it on latest Flame KK build Comment 21 mentioned, we need to verify this patch on Nexus-5 or Madai.
Status: RESOLVED → VERIFIED
cannot reproduce it on Madai build KAG07d_pre1 wait nexus-5 result
nexus-5 also cannot reproduce this problem Gaia-Rev 2a612867039a7cfb3af6e692bfae4482b06705e9 Gecko-Rev Build ID 20140919143725 Version 34.0a2 Device Name hammerhead FW-Release 4.4.2 FW-Incremental eng.mikel.20140918.154302 FW-Date 四 9月 18 15:43:31 CST 2014 Bootloader HHZ11k
This issue has been verified successfully on Flame 2.0 & 2.1. See attachment: Verify_Video_Flame.MP4 Reproducing rate: 0/10 Flame v2.0 version: Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3 Build-ID 20141201000201 Version 32.0 Flame v2.1 version: Gaia-Rev ccb49abe412c978a4045f0c75abff534372716c4 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22 Build-ID 20141201001201 Version 34.0
You need to log in before you can comment on or make changes to this bug.