Free space in account central different under email and accounts

RESOLVED FIXED in Thunderbird 33.0

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: merike, Assigned: Paenglab)

Tracking

31 Branch
Thunderbird 33.0
All
Linux
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 8436347 [details]
accountCentral.png

Free space below last item in Email section and below last item in Accounts is different. That's a bit disturbing visually, especially if Lightning is installed which makes it more noticeable by adding one extra item there.

It's probably the same way in trunk but I don't have that build at the moment to check.
(Assignee)

Comment 1

5 years ago
Created attachment 8436356 [details] [diff] [review]
noHeight.patch

Yeah, this height definition isn't needed.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8436356 - Flags: review?(josiah)
(Reporter)

Comment 2

5 years ago
Does removing that 50px rule make the space equal for you? For me it just reverses the difference. So without the patch the space in Accounts section is bigger and with the patch the space in Email section is bigger.
(Assignee)

Comment 3

5 years ago
Comment on attachment 8436356 [details] [diff] [review]
noHeight.patch

(In reply to Merike (:merike) from comment #2)
> Does removing that 50px rule make the space equal for you? For me it just
> reverses the difference. So without the patch the space in Accounts section
> is bigger and with the patch the space in Email section is bigger.

That's correct. I'm on a new patch.
Attachment #8436356 - Flags: review?(josiah)
(Assignee)

Comment 4

5 years ago
Created attachment 8436741 [details] [diff] [review]
AccountSpace.patch

This one should work better. It's not easily possible to make this pixel perfect as the icons of the main rows and CreateAccounts row don't have the same icon sizes.

Also should this whole page need a overhaul as the main row icons aren't correctly aligned with the text etc. Also are the three platforms slightly different implemented. OS X for example hides the spacers which makes the page compcter than on Linux and Windows.

But I thought Josiah was already on a refresh and showed a mockup of a new page about one month ago.
Attachment #8436356 - Attachment is obsolete: true
Attachment #8436741 - Flags: review?(josiah)
I'm going to review this later today, but yes, I am working on a refresh. See here: http://jsfiddle.net/aG7HU/34/embedded/result/
Comment on attachment 8436741 [details] [diff] [review]
AccountSpace.patch

Review of attachment 8436741 [details] [diff] [review]:
-----------------------------------------------------------------

Good enough until the refresh I guess. Thanks.
Attachment #8436741 - Flags: review?(josiah) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/97972f4ff0e8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
(Assignee)

Updated

4 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.