Closed
Bug 1022222
Opened 10 years ago
Closed 10 years ago
Free space in account central different under email and accounts
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 33.0
People
(Reporter: merike, Assigned: Paenglab)
Details
Attachments
(2 files, 1 obsolete file)
25.87 KB,
image/png
|
Details | |
3.85 KB,
patch
|
jsbruner
:
review+
|
Details | Diff | Splinter Review |
Free space below last item in Email section and below last item in Accounts is different. That's a bit disturbing visually, especially if Lightning is installed which makes it more noticeable by adding one extra item there. It's probably the same way in trunk but I don't have that build at the moment to check.
Assignee | ||
Comment 1•10 years ago
|
||
Yeah, this height definition isn't needed.
Reporter | ||
Comment 2•10 years ago
|
||
Does removing that 50px rule make the space equal for you? For me it just reverses the difference. So without the patch the space in Accounts section is bigger and with the patch the space in Email section is bigger.
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8436356 [details] [diff] [review] noHeight.patch (In reply to Merike (:merike) from comment #2) > Does removing that 50px rule make the space equal for you? For me it just > reverses the difference. So without the patch the space in Accounts section > is bigger and with the patch the space in Email section is bigger. That's correct. I'm on a new patch.
Attachment #8436356 -
Flags: review?(josiah)
Assignee | ||
Comment 4•10 years ago
|
||
This one should work better. It's not easily possible to make this pixel perfect as the icons of the main rows and CreateAccounts row don't have the same icon sizes. Also should this whole page need a overhaul as the main row icons aren't correctly aligned with the text etc. Also are the three platforms slightly different implemented. OS X for example hides the spacers which makes the page compcter than on Linux and Windows. But I thought Josiah was already on a refresh and showed a mockup of a new page about one month ago.
Attachment #8436356 -
Attachment is obsolete: true
Attachment #8436741 -
Flags: review?(josiah)
Comment 5•10 years ago
|
||
I'm going to review this later today, but yes, I am working on a refresh. See here: http://jsfiddle.net/aG7HU/34/embedded/result/
Comment 6•10 years ago
|
||
Comment on attachment 8436741 [details] [diff] [review] AccountSpace.patch Review of attachment 8436741 [details] [diff] [review]: ----------------------------------------------------------------- Good enough until the refresh I guess. Thanks.
Attachment #8436741 -
Flags: review?(josiah) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/97972f4ff0e8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
Assignee | ||
Updated•9 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•