1022254 - JS Date with integer literals with leading zeroes is broken due to bug 957513

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Anshu Prateek]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:32.0) Gecko/20100101 Firefox/32.0 (Beta/Release)
Build ID: 20140607030208

Steps to reproduce:

Sites having date in JS are broken:

in console, enter -

date = new Date(2013,08,12);



Actual results:

The respective JS is broken
X SyntaxError: numbers starting with 0 followed by a digit are octals and can't contain 8


Expected results:

respective JS should be parsed and the site should work.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Sounds to me like the spec is not web-compatible here and needs to change.

Comment 2

[Kohei Yoshino]

I'm not sure the reported case is common. The result of new Date(2013,08,12) may not what the author expected; It's actually 2013-09-12 since the month is an integer beginning with 0 for January to 11 for December. So developers usually have to +1 in their code, then the value won't be zero-prefixed.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date

Comment 3

[Anshu Prateek]

Mm, the handling of +1 could be managed on server side as well I guess?

Comment 4

[Chris Peterson [:cpeterson]]

Till backed out bug 957513 from Aurora 32, but let's track this for 33. If we can't get this bug fixed soon, we may need to back bug 957513 out of 33, too.

Comment 5

[Chris Peterson [:cpeterson]]

Jason: does this Date bug suggest that we can never enable the octal syntax errors?

IIUC, bz asserts in comment 1 that the ES6 spec's octal syntax error is not web-compatible, but I agree with Kohei in comment 2 that these syntax errors are reporting likely content bugs. Should we downgrade the syntax errors to console warnings for the indefinite future?

Comment 6

[Jason Orendorff [:jorendorff]]

(In reply to Chris Peterson (:cpeterson) from comment #5)
> Jason: does this Date bug suggest that we can never enable the octal syntax
> errors?

Yes.

> IIUC, bz asserts in comment 1 that the ES6 spec's octal syntax error is not
> web-compatible, but I agree with Kohei in comment 2 that these syntax errors
> are reporting likely content bugs.

Sure. Suppose both are true. Then we can never enable the octal syntax errors.

As a wise man once told me: Don't break the web.

> Should we downgrade the syntax errors to
> console warnings for the indefinite future?

Yep.

Comment 7

[Timvde]

This also broke the KU Leuven exam schedule in Nightly. Error happens here: |new Date(2014,00,10,08,30)|

Comment 8

[Benjamin Kerensa [:bkerensa]]

Tracking this for now

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Who's taking this?

Comment 11

[Simonas Kazlauskas [:nagisa/:simukis]]

Can we downgrade the error to warning instead of removing the functionality altogether?

Comment 12

[Simonas Kazlauskas [:nagisa/:simukis]]

(In reply to Simonas Kazlauskas [:simukis] from comment #11)
> Can we downgrade the error to warning instead of removing the functionality
> altogether?

Please ignore. I did not look at bug 957513 hard enough before writing here.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Untracking. We are already tracking this issue in bug 957513.

Comment 14

[Dave Garrett]

Bug 957513 was backed out fully and closed as WONTFIX. Closing this.