Closed Bug 1022283 Opened 6 years ago Closed 6 years ago

NetworkGeolocationProvider: Change timer to timeout ONLY if wifi subsystem not calling back

Categories

(Core :: DOM: Geolocation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33
blocking-b2g 1.4+
Tracking Status
firefox31 --- wontfix
firefox32 --- fixed
firefox33 --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(1 file)

The timer in the NetworkGeolocationProviders fires faster than it needs, and doesn't rearm it self.  What we should be doing is using the timer in the provider to fire when we stop getting WiFi data.
Attached patch bug_1022283Splinter Review
Attachment #8436435 - Flags: review?(josh)
Comment on attachment 8436435 [details] [diff] [review]
bug_1022283

It's a repeating timer; why do we need to reset it?
doh.  my assumption is that it was!
Sorry, that wasn't very clear.  I want to reset it so that it does *not* fire. Basically, i want to keep delaying the timer callback while things are working well.
Attachment #8436435 - Flags: review?(josh) → review+
Summary: Increase timeout for NetworkGeolocationProvider to 15s → NetworkGeolocationProvider: Change timer to timeout ONLY if wifi subsystem not calling back
https://hg.mozilla.org/mozilla-central/rev/c935b461efdf
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
blocking-b2g: --- → 1.4?
OS: Linux → All
Hardware: x86_64 → All
Taking in 1.4 for incorrect time display.
blocking-b2g: 1.4? → 1.4+
Needs rebased patches for b2g30/aurora uplift.
Doug: Ryan says you need to rebase this patch.
Flags: needinfo?(dougt)
You need to log in before you can comment on or make changes to this bug.