Closed
Bug 1022348
Opened 10 years ago
Closed 10 years ago
Use the C/C++ compilers passed in through mozconfig in order to preprocess on Windows instead of hardcoding the usage of cl
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8436487 -
Flags: review?(mh+mozilla)
Comment 2•10 years ago
|
||
Comment on attachment 8436487 [details] [diff] [review] Use the C/C++ compilers passed in through mozconfig in order to preprocess on Windows instead of hardcoding the usage of cl Review of attachment 8436487 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/autoconf/compiler-opts.m4 @@ +25,5 @@ > *-mingw*) > if test -z "$CC"; then CC=cl; fi > if test -z "$CXX"; then CXX=cl; fi > + if test -z "$CPP"; then CPP="$CC -E -nologo"; fi > + if test -z "$CXXCPP"; then CXXCPP="$CXX -TP -E -nologo"; ac_cv_prog_CXXCPP="$CXXCPP"; fi Note -nologo also assumes cl, but meh.
Attachment #8436487 -
Flags: review?(mh+mozilla) → review+
Comment 3•10 years ago
|
||
(-TP, too)
Assignee | ||
Comment 4•10 years ago
|
||
clang-cl accepts -nologo just fine. same as -TP. http://clang.llvm.org/docs/UsersManual.html
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/85ddc0b5770e
https://hg.mozilla.org/mozilla-central/rev/85ddc0b5770e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Comment 7•10 years ago
|
||
FYI this looks as if it breaks pymake builds because there everything becomes %mozbuild.action.cl and therefore embedjs.py doesn't know how to preprocess.
Comment 8•10 years ago
|
||
Time to kill pymake for good, then.
Assignee | ||
Comment 9•10 years ago
|
||
Err, so does that mean that this patch breaks the builds of those who use pymake locally? :(
Comment 10•10 years ago
|
||
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #9) > Err, so does that mean that this patch breaks the builds of those who use > pymake locally? :( Yes, and I don't really care. In fact, I'm going to file a bug to reject pymake builds.
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•