1022348 - Use the C/C++ compilers passed in through mozconfig in order to preprocess on Windows instead of hardcoding the usage of cl

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[(no longer active)]

Attachment: Use the C/C++ compilers passed in through mozconfig in order to preprocess on Windows instead of hardcoding the usage of cl

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8436487 [details] [diff] [review]
Use the C/C++ compilers passed in through mozconfig in order to preprocess on Windows instead of hardcoding the usage of cl

Review of attachment 8436487 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/autoconf/compiler-opts.m4
@@ +25,5 @@
>  *-mingw*)
>      if test -z "$CC"; then CC=cl; fi
>      if test -z "$CXX"; then CXX=cl; fi
> +    if test -z "$CPP"; then CPP="$CC -E -nologo"; fi
> +    if test -z "$CXXCPP"; then CXXCPP="$CXX -TP -E -nologo"; ac_cv_prog_CXXCPP="$CXXCPP"; fi

Note -nologo also assumes cl, but meh.

Comment 3

[Mike Hommey [:glandium]]

(-TP, too)

Comment 4

[(no longer active)]

clang-cl accepts -nologo just fine.  same as -TP.  http://clang.llvm.org/docs/UsersManual.html

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/85ddc0b5770e

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/85ddc0b5770e

Comment 7

[[e-mail]]

FYI this looks as if it breaks pymake builds because there everything becomes %mozbuild.action.cl and therefore embedjs.py doesn't know how to preprocess.

Comment 8

[Mike Hommey [:glandium]]

Time to kill pymake for good, then.

Comment 9

[(no longer active)]

Err, so does that mean that this patch breaks the builds of those who use pymake locally? :(

Comment 10

[Mike Hommey [:glandium]]

(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #9)
> Err, so does that mean that this patch breaks the builds of those who use
> pymake locally? :(

Yes, and I don't really care. In fact, I'm going to file a bug to reject pymake builds.