1022349 - Use the C/C++ compilers passed in through mozconfig in order to preprocess libffi on Windows instead of hardcoding the usage of cl

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[(no longer active)]

Attachment: Use the C/C++ compilers passed in through mozconfig in order to preprocess libffi on Windows instead of hardcoding the usage of cl

Comment 2

[(no longer active)]

Comment on attachment 8436488 [details] [diff] [review]
Use the C/C++ compilers passed in through mozconfig in order to preprocess libffi on Windows instead of hardcoding the usage of cl

This actually breaks clang-cl builds.

Comment 3

[(no longer active)]

Filed an LLVM bug to add support for -EP.  This would be trivial to work around by just using -E, except that I also realized that the msvcc.sh script forces usage of cl no matter what the main configure script does.  glandium, can we take a local patch to msvcc.sh?

Comment 4

[Mike Hommey [:glandium]]

(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #3)
> glandium, can we take a local patch to msvcc.sh?

We can even upstream it. I don't think upstream would mind, we're essentially the ones maintaining that file.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Upstream is very friendly towards taking patches. Can you submit a pull request?

Comment 6

[(no longer active)]

Done: https://github.com/atgreen/libffi/pull/123

What's our process of taking upstream changes for libffi?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

We can just land it locally for now with an in-tree patch and grab the upstream update whenever.

Comment 8

[(no longer active)]

Attachment: Part 1: Apply the upstream patch to add support for clang-cl to libffi; r=glandium

Comment 9

[(no longer active)]

Attachment: Part 2: Use clang-cl when building libffi if we're building with clang-cl; r=glandium

Comment 10

[(no longer active)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #7)
> We can just land it locally for now with an in-tree patch and grab the
> upstream update whenever.

glandium asked me to add a local patch to libffi-patches.

Comment 11

[Mike Hommey [:glandium]]

Comment on attachment 8439618 [details] [diff] [review]
Part 2: Use clang-cl when building libffi if we're building with clang-cl; r=glandium

Review of attachment 8439618 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/autoconf/ffi.m4
@@ +54,5 @@
>        fi
> +      clangcl=
> +      if test -n "$CLANG_CL"; then
> +        clangcl=" -clang-cl"
> +      fi

I'd rather rename rtl and append to it. That'd live a single variable used below instead of adding another one.

Comment 12

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c06b086e8b0
https://hg.mozilla.org/integration/mozilla-inbound/rev/3aada4e364ab

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5c06b086e8b0
https://hg.mozilla.org/mozilla-central/rev/3aada4e364ab
https://hg.mozilla.org/mozilla-central/rev/0b37d9e5112f