1022396 - remove Number.toInteger

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[:Benjamin Peterson]

When I implemented Number.toInteger in bug 761495, it was part of the ES6 draft spec. It has since been removed. No other engine implements it and according to DXR, its use in Gecko is limited to its own testsuite. Therefore, let's remove it.

Comment 1

[:Benjamin Peterson]

Attachment: rm-nti.patch

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 8436538 [details] [diff] [review]
rm-nti.patch

Review of attachment 8436538 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 3

[:Benjamin Peterson]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc1936b69cbf

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fc1936b69cbf

Comment 5

[Florian Scholz (Open Web Docs)]

Reference page updated:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toInteger

Added to Firefox 33 for developers:
https://developer.mozilla.org/en-US/Firefox/Releases/33#JavaScript

Comment 6

[blindwanderer]

Since it is being removed, what is the recommended alternative?

Comment 7

[Jeff Walden [:Waldo]]

Why not just write it out by hand?

function ToInteger(v)
{
  var n = +v;
  if (!n)
    return n;
  return n < 0 ? Math.ceil(n) : Math.floor(n);
}