1022423 - [homescreen] App names disappear after switching locale

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Théo Chevalier]

STR:
1. Go to settings, switch to another locale (French for instance)
2. Go back to homescreen

Actual:
There is no more App name on homescreen until you reboot the phone

Expected:
localized App names

Comment 1

[Kevin Grandon :kgrandon]

Most likely a gecko regression, potentially with updating content inside web components. It should be possible to fine a workaround if we can't get a platform fix.

Théo - can you provide gaia/gecko revisions for the build you've seen this on?

Comment 2

[Théo Chevalier]

(In reply to Kevin Grandon :kgrandon from comment #1)
> Most likely a gecko regression, potentially with updating content inside web
> components. It should be possible to fine a workaround if we can't get a
> platform fix.
> 
> Théo - can you provide gaia/gecko revisions for the build you've seen this
> on?

Sure, latest Flame OTA:

Gaia      2e5636e852a9354a5f8072b179cf16f72647cfd6
Gecko     https://hg.mozilla.org/mozilla-central/rev/8bd92dc9ef59
BuildID   20140608160201
Version   32.0a1
ro.build.version.incremental=eng.cltbld.20140530.074449
ro.build.date=Fri May 30 07:44:59 EDT 201

Comment 3

[Francesco Lodolo [:flod]]

I'm seeing this also on Keon, which I flashed for bug 1021121 (icons showed up localized, I didn't try to switch language).

Build ID  20140606094222
Version   32.0a1
Git commit info: 2014-06-06 06:69:50 a2ca14d6

Comment 4

[Jason Smith [:jsmith]]

Actually I don't think this is a FL blocker. Locale switching isn't considered a basic use case.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #4)
> Actually I don't think this is a FL blocker. Locale switching isn't
> considered a basic use case.

Actually after talking with Johan, this is a critical regression that is going to block usage of the phone by anyone outside of the US, so we probably need to FL block it.

Comment 6

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 7

[Jason Smith [:jsmith]]

Per discussion with tchung, ctalbert, and lucas, a FL blocker must be a broken use case, so this isn't a blocker.

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8437182 [details] [review]
Github pull request

This is a really bad hack! Luckily we have a platform bug being worked on that will allow us to turn this off, but for 2.0 we should land this first I think.

Cristian - have time to take a look? (Note we have an integration test for this issue, but it still passes, so there's not too much we can test without reftests. Hopefully the platform fix will have some tests for this though)

Comment 9

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8437182 [details] [review]
Github pull request

Well, this is a workaround needed so go ahead, 10x r=me

Comment 10

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/8b7ecdfbd5bca2cad1e46dd2f9b0bafa74adf931

Comment 11

[Cristian Rodriguez (:crdlc)]

Who is in charge of uplifting 2.0+ bugs?

Comment 12

[Kevin Grandon :kgrandon]

I think they should auto-uplift from our good sheriff friends. I'll check on timing of uplifts tomorrow.

Comment 13

[Kevin Grandon :kgrandon]

Comment on attachment 8437182 [details] [review]
Github pull request

This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.

Comment 14

[Kevin Grandon :kgrandon]

Uplifted: https://github.com/mozilla-b2g/gaia/commit/eef732725cc1e62a8fa4ef4afafb071fa4e9dcde

Comment 15

[Johan Lorenzo [:jlorenzo]]

Verified on v2.0 branch.

Comment 16

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0

Flame v2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0