[homescreen] App names disappear after switching locale

VERIFIED FIXED in Firefox OS v2.0

Status

VERIFIED FIXED
5 years ago
2 years ago

People

(Reporter: tchevalier, Assigned: kgrandon)

Tracking

({regression})

unspecified
2.0 S4 (20june)
x86_64
Linux
regression
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments)

STR:
1. Go to settings, switch to another locale (French for instance)
2. Go back to homescreen

Actual:
There is no more App name on homescreen until you reboot the phone

Expected:
localized App names

Updated

5 years ago
Blocks: 1015336
Whiteboard: [systemsfe]
(Assignee)

Comment 1

5 years ago
Most likely a gecko regression, potentially with updating content inside web components. It should be possible to fine a workaround if we can't get a platform fix.

Théo - can you provide gaia/gecko revisions for the build you've seen this on?
Flags: needinfo?(tchevalier)
Keywords: regression
(In reply to Kevin Grandon :kgrandon from comment #1)
> Most likely a gecko regression, potentially with updating content inside web
> components. It should be possible to fine a workaround if we can't get a
> platform fix.
> 
> Théo - can you provide gaia/gecko revisions for the build you've seen this
> on?

Sure, latest Flame OTA:

Gaia      2e5636e852a9354a5f8072b179cf16f72647cfd6
Gecko     https://hg.mozilla.org/mozilla-central/rev/8bd92dc9ef59
BuildID   20140608160201
Version   32.0a1
ro.build.version.incremental=eng.cltbld.20140530.074449
ro.build.date=Fri May 30 07:44:59 EDT 201
Flags: needinfo?(tchevalier)

Updated

5 years ago
blocking-b2g: 2.0? → 2.0+
I'm seeing this also on Keon, which I flashed for bug 1021121 (icons showed up localized, I didn't try to switch language).

Build ID  20140606094222
Version   32.0a1
Git commit info: 2014-06-06 06:69:50 a2ca14d6
QA Whiteboard: [VH-FL-blocking+]
Actually I don't think this is a FL blocker. Locale switching isn't considered a basic use case.
QA Whiteboard: [VH-FL-blocking+] → [VH-FL-blocking-]
(In reply to Jason Smith [:jsmith] from comment #4)
> Actually I don't think this is a FL blocker. Locale switching isn't
> considered a basic use case.

Actually after talking with Johan, this is a critical regression that is going to block usage of the phone by anyone outside of the US, so we probably need to FL block it.
QA Whiteboard: [VH-FL-blocking-] → [VH-FL-blocking+]
(Assignee)

Updated

5 years ago
Depends on: 1022866
(Assignee)

Comment 6

5 years ago
Created attachment 8437182 [details] [review]
Github pull request
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Target Milestone: --- → 2.0 S4 (20june)
Per discussion with tchung, ctalbert, and lucas, a FL blocker must be a broken use case, so this isn't a blocker.
QA Whiteboard: [VH-FL-blocking+] → [VH-FL-blocking-]
(Assignee)

Comment 8

5 years ago
Comment on attachment 8437182 [details] [review]
Github pull request

This is a really bad hack! Luckily we have a platform bug being worked on that will allow us to turn this off, but for 2.0 we should land this first I think.

Cristian - have time to take a look? (Note we have an integration test for this issue, but it still passes, so there's not too much we can test without reftests. Hopefully the platform fix will have some tests for this though)
Attachment #8437182 - Flags: review?(crdlc)
Comment on attachment 8437182 [details] [review]
Github pull request

Well, this is a workaround needed so go ahead, 10x r=me
Attachment #8437182 - Flags: review?(crdlc) → review+
Merged in master:

https://github.com/mozilla-b2g/gaia/commit/8b7ecdfbd5bca2cad1e46dd2f9b0bafa74adf931
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Who is in charge of uplifting 2.0+ bugs?
(Assignee)

Comment 12

5 years ago
I think they should auto-uplift from our good sheriff friends. I'll check on timing of uplifts tomorrow.
status-b2g-v2.0: --- → affected
status-b2g-v2.1: --- → fixed
QA Whiteboard: [VH-FL-blocking-] → [VH-FL-blocking-][VH-FC-blocking+]
(Assignee)

Comment 13

5 years ago
Comment on attachment 8437182 [details] [review]
Github pull request

This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.
Attachment #8437182 - Flags: approval-gaia-v2.0?(bbajaj)

Updated

5 years ago
Attachment #8437182 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Verified on v2.0 branch.
Status: RESOLVED → VERIFIED
Flags: in-moztrap?(tchevalier)
Created attachment 8531111 [details]
Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0

Flame v2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0
status-b2g-v2.0: fixed → verified
status-b2g-v2.1: fixed → verified
Flags: in-moztrap?(theo)
You need to log in before you can comment on or make changes to this bug.