Closed Bug 1022429 Opened 5 years ago Closed 5 years ago

[Homescreen] Flatter design for notification tray.

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set

Tracking

(b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S5 (4july)
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: hnguyen, Assigned: nefzaoui)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken [ucid:SystemPlatform60, 2.0, ft:system-platform])

Attachments

(5 files)

Updating the notification tray to a flat design to match the visual design language of 2.0. 

Please see specification for further details. 

Thanks
QA Whiteboard: [VH-FC-blocking+]
QA Whiteboard: [VH-FC-blocking+] → [VH-FC-blocking-]
This is unrelated to the vertical homescreen.
QA Whiteboard: [VH-FC-blocking-]
Component: Gaia::Homescreen → Gaia::System
Whiteboard: ux-tracking, visual design, visual-tracking, bokken [ucid:SystemPlatform60, 2.0, ft:system-platform]
Taking if nobody else is already working on it. :)
Assignee: nobody → nefzaoui.ahmed
Pretty done, however I'm seeing other UI gradients that aren't covered in the spec..
Attachment #8443579 - Flags: review?(alive)
Comment on attachment 8443579 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20812

r=me
Attachment #8443579 - Flags: review?(alive) → review+
Umm.. Alive can you please merge for me if all is well? I don't have write access, I'm just a contributor. :)
(In reply to Ahmed Nefzaoui [:Nefzaoui] from comment #5)
> Umm.. Alive can you please merge for me if all is well? I don't have write
> access, I'm just a contributor. :)

Could you flag ui review to Peter La? And if everything is ok, put 'checkin-needed' in keywords then someone will merge for you!
Attachment #8444144 - Flags: ui-review?(pla)
Comment on attachment 8444144 [details]
Screenshot - After Patch

Hi Ahmed,

Thanks for contributing!  This is looking great.  There is just one small detail you missed.  There is a thin vertical line on the left side (next the where it says 2.41 MB).  If you can get rid of that line so that it is flat grey throughout, that would make it perfect.

See my next comment for attachment showing exactly where.

Thanks!
Peter
Attachment #8444144 - Flags: ui-review?(pla) → ui-review-
Comment on attachment 8443579 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20812

Patch updated, asking for r? to make sure everything's fine and I haven't forgot anything. :)
Will be attaching screenshot for ui-review

Thanks
Attachment #8443579 - Flags: review+ → review?(alive)
Attached image 2014-06-23-18-17-33.png
Issue addressed.
Attachment #8444533 - Flags: ui-review?(pla)
Comment on attachment 8444533 [details]
2014-06-23-18-17-33.png

Lookin' good!  Thanks Ahmed!
Attachment #8444533 - Flags: ui-review?(pla) → ui-review+
Attachment #8443579 - Flags: review?(alive) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/f10cd69665c2570e55a8b56546a5ae374d01eea9

Also blocking homescreen to keep track of necessary uplifts.
Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Comment on attachment 8443579 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20812

This is a low risk visual polish patch which UX would like to have for the vertical homescreen.
Attachment #8443579 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8443579 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
You need to log in before you can comment on or make changes to this bug.