1022450 - [Flame][V1.4][Dialer]The key press tone will distort when you tap the number key during the call.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[panda67231]

Attachment: video_tone.mp4

[1.Description]:
The key press tone will distort when you tap the number key during the call. It will make user feel uncomfortable.

Attach the video: video_tone.mp4
Attach the logs: logcat_tone.txt & bugreport_tone.txt

Happened time: 11:54AM

[2.Testing Steps]: 
1. Make a call to 10086
2. Innvoke the keypad during the call
3. Tap the number key during the call

[3.Expected Result]: 
3. The key press tone should not distort.

[4.Actual Result]: 
3. The key press tone will distort.

[5.Reproduction build]: 
Gaia        7709936aeb21859d1607dbd038489493803bb085
Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/5bf038fae0f1
BuildID    20140522160202
Version    30.0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

Comment 1

[panda67231]

Attachment: bugreport_tone.txt

Comment 2

[panda67231]

Attachment: logcat_tone.txt

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

This is the same issue we've experienced in bug 917193 and bug 988760; we've deployed a workaround for the busy tone in bug 988760 which *might* fix this issue too; I'll give it a try and see if it fixes this.

However the real issue is bug 848954 so I'm marking that as blocking.

Comment 4

[Julien Wajsberg [:julienw]]

The patch for bug 1022554 has a wrong commit log that points to this bug, sorry about this, and sorry that I didn't check before merging :-(

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: [PATCH] Workaround for glitchy long-press key tones

This patch extends the existing workaround for glitchy short key-tones to the long ones. The day bug 848954 gets fixed and we can get rid of this stuff I'll be a happy coder. Like, real happy.

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: [PULL REQUEST] Workaround for glitchy long-press key tones

Can you try out this PR and see if it fixes the problem for you? It does for me on Flame and Hamachi devices.

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8456128 [details] [diff] [review]
[PATCH] Workaround for glitchy long-press key tones

Review of attachment 8456128 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good. Literally.

Comment 8

[Gabriele Svelto [:gsvelto] (PTO)]

Try was mostly green except for an unrelated integration test that I've seen failing more than once, I've re-triggered it but maybe it's time to mark it as an intermittent issue or something. Anyway pushed to gaia/master 8c702cb54f73683e9681508a8eff2d3ac9bb9109

https://github.com/mozilla-b2g/gaia/commit/8c702cb54f73683e9681508a8eff2d3ac9bb9109