Closed Bug 1022463 Opened 6 years ago Closed 6 years ago

Use 10 seconds as the max time to wait for GPS data before using MLS

Categories

(Core :: DOM: Geolocation, defect)

Product:
Core
Component:
DOM: Geolocation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
firefox31 --- wontfix
firefox32 --- fixed
firefox33 --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(1 file)

bug_1022463
1.30 KB, patch
kanru
: review+
Details | Diff | Splinter Review 
Currently we are seeing fluxuatoin between GPS derived data and MLS data due to a very short timeout (kDefaultPeriod == 1s).  Basically what is happening is GPS sometimes takes more than 1 second to return a position.  In this case, we might switch back to providing a MLS location.  We should use something longer than 1s.  I have been playing around with 5-10 seconds and do not see this flux problem any longer.

I am picking 10s mostly because I want to give GPS as much possible time before hititng MLS for a much less accurate position.
Attached patch bug_1022463 — — Splinter Review
Attachment #8436645 - Flags: review?(josh)
Attachment #8436645 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/0ae930b73fd5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
blocking-b2g: --- → 1.4?
OS: Linux → All
Hardware: x86_64 → All
blocking-b2g: 1.4? → 1.4+
Doug: did you forget to land this 1.4+ fix on the mozilla-b2g30 branch?
Flags: needinfo?(dougt)
Doug: Ryan says you need to rebase this patch for 1.4.
working on rebasing.
Flags: needinfo?(dougt)
You need to log in before you can comment on or make changes to this bug.