1022468 - Infinite loop reading small-shot.m4a in MP4Reader

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

If you load small-shot.m4a from a local file on Windows in the MP4Reader, you get stuck in a loop. The problem is that MP4Stream::ReadAt() isn't detecting end of stream correctly. When we reach EOS, MediaResource::ReatAt() report 0 bytes read and returns success. But when that happens we're not getting out of the loop in MP4Stream::ReadAt(), as that only exits if MediaResource::ReatAt() returns failure or if we read the requested number of bytes.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Fix: Exit loop on EOS.

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

If this is a difference between the way a local file works compared to a network connection then this should probably be fixed closer to the root of the problem.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c338d5c07d8

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1c338d5c07d8