1022495 - cfx run no longer works with Firefox 29.0.1

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Description

[François Marier [:francois]]

Steps to reproduce:

1. Install Firefox 29.0.1 as default browser (I grabbed the Linux 64 English release from https://www.mozilla.org/en-US/firefox/all/)
2. git clone https://github.com/mozilla/lightbeam.git
3. cd lightbeam ; cfx run

Expected:

Firefox should open with the add-on loaded.

Actual:

Firefox opens but the add-on is not loaded and instead the following messages appears on the console:

    console.error: lightbeam: 
      Error opening input stream (invalid filename?)
    console.error: lightbeam: 
      Error opening input stream (invalid filename?)

Comment 1

[François Marier [:francois]]

Attachment: revert_bad_commit.patch

After bisecting this problem, I found the culprit:

  40ee655d79d9f21c34d96828cd9fe48bc8e66b15 is the first bad commit

and if I "git revert" that commit, I can make "cfx run" work again.

The attached patch is the revert I tested, not necessarily a proposed fix.

Comment 2

[François Marier [:francois]]

Attachment: smaller_fix.patch

Here's a much smaller change which fixes the problem with cfx run.

Again, I don't really understand what I'm doing, so it's not really a proposed fix, but hopefully it will help point in the right direction.

Comment 3

[Tomislav Jovanovic :zombie]

hi François, the master branch from github is only meant to be used with Nightly, please use release version of the sdk (1.16) for running with release Firefox 29 (and beta 30).

Comment 4

[François Marier [:francois]]

Ok, I've updated the instructions on MDN (https://developer.mozilla.org/en-US/Add-ons/SDK/Tutorials/Installation) to hopefully make sure that others don't fall into the same trap.

Can I rely on the "firefox29" branch in the github repo?

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to François Marier [:francois] from comment #4)
> Ok, I've updated the instructions on MDN
> (https://developer.mozilla.org/en-US/Add-ons/SDK/Tutorials/Installation) to
> hopefully make sure that others don't fall into the same trap.
> 
> Can I rely on the "firefox29" branch in the github repo?

The various firefoxXX branches should all correctly run with their corresponding XX version of Firefox, yes, though if you're building addons and submitting them to AMO, it might not pass review for using a non-release version of the SDK code.

Comment 6

[Tomislav Jovanovic :zombie]

(In reply to François Marier [:francois] from comment #4)
> Ok, I've updated the instructions on MDN
> (https://developer.mozilla.org/en-US/Add-ons/SDK/Tutorials/Installation) to
> hopefully make sure that others don't fall into the same trap.

also, thanks for fixing this François! 

a few other devs have had the same issues, didn't know where they were getting the info from..