1022500 - cloning a firefox tracking flags throws "The component named 'Template::Document=HASH(0x7f7ffacdb4c8)' does not exist. "

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[:glob ✱]

cloning a firefox tracking flags throws "The component named 'Template::Document=HASH(0x7f7ffacdb4c8)' does not exist. "

this didn't happen for the thunderbird fields, nor on my dev box, and the generated html doesn't contain Template::Document.

investigating; we have an uplift tomorrow.

Comment 1

[:glob ✱]

this is happening because the component 'Mozmill Automation' was moved to the graveyard however the tracking flags table was not updated by the movecomponent.pl script.

additionally, 'component' is already default by template::toolkit, resulting in the confusing error message.


i will:
- fix the error message when an invalid component is used
- add a hook to movecomponent.pl so the trackingflags ext can update its tables
- look for other tables which may be impacted by this issue
- write a sanitycheck routine to fix the broken rows

Comment 2

[:glob ✱]

Attachment: 1022500_1.patch

- adds reorg_move_component hook to movecomponent.pl
- some refactoring of movecomponent.pl
- adds move_component and sanity_repair to tracking-flags ext
- adds move_component and sanity_repair to component-watching ext
- fixes tracking flags error message

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8436787 [details] [diff] [review]
1022500_1.patch

Review of attachment 8436787 [details] [diff] [review]:
-----------------------------------------------------------------

Fixes on commit. Otherwise looked good and worked as expected. r=dkl

::: contrib/reorg-tools/movecomponent.pl
@@ +81,3 @@
>  # confirmation
>  print <<EOF;
>  About to move the component '$component'

s/$component/$component_name/

@@ +87,5 @@
>  Press <Ctrl-C> to stop or <Enter> to continue...
>  EOF
>  getc();
>  
> +print "Moving '$component' from '$old_product_name' to '$new_product_name'...\n\n";

s/$component/$component_name/

Comment 4

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   f0cab24..d9b38fd  master -> master