1022506 - Search results app uses a white icon, rather than a dedicated nicer looking app icon

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Jason Smith [:jsmith]]

Attachment: Screenshot

Build

* Device: Flame
* Version: 2.0 - b2g-inbound
* Build ID: 20140608173002
* Gaia: 12af93123c5db55212d51fe235d39f21209a1eaa
* Gecko: 7f3f35b511f8

STR

1. Go to app permissions

Expected

The search results app should have a nicer looking app icon representative of the app.

Actual

The search results app has a white icon.

Comment 1

[Kevin Grandon :kgrandon]

Peter, seems like we'll also need an icon here. This is for the "search results" app permissions, the search results app is the app that opens up when you focus on the rocketbar.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Noming for blocking as we should ship with an icon for the search app.  
We would need a @1.5x @2x @2.25x as well I think for the manifest?

Comment 3

[Stephany Wilkes]

Agree with blocking call. Thanks Naoki! Peter La is the correct person for the icon and is already flagged, so I'll leave that flag set.

Comment 4

[Peter La]

Thanks for pointing this out guys.  I was about to file a bug for it.  I'll attach the icon tonight.

Leaving NI flag on so I remember.

Comment 5

[Peter La]

Attachment: SearchResultsIcon-20140717.zip

Here is the icon for Search Results for App Permissions.

Comment 6

[Peter La]

Attachment: AppPermissionsIcons-Mockup.jpg

And here is the mockup of how it looks in context.

Comment 7

[[e-mail]]

Hi I've seen several app use 84/126/142/189/284 instead of @2x.png style

The provided size are 80/126/142/189/256/284 . should the 80x80 icon be 84x84?

Comment 8

[[e-mail]]

Attachment: pull request redirect to github

wait for icon size feedback before review

Comment 9

[Peter La]

(In reply to Fred Lin [:gasolin] from comment #7)
> Hi I've seen several app use 84/126/142/189/284 instead of @2x.png style
> 
> The provided size are 80/126/142/189/256/284 . should the 80x80 icon be
> 84x84?

Hi Fred,

If you've seen reference to 84, then that is a mistake.  There have never been icons shipped at 84.  The sizes should be 80/126/142/189/256/284 and we always shipped them in those sizes for 2.0.

Comment 10

[Peter La]

(In reply to Peter La from comment #9)
> (In reply to Fred Lin [:gasolin] from comment #7)
> > Hi I've seen several app use 84/126/142/189/284 instead of @2x.png style
> > 
> > The provided size are 80/126/142/189/256/284 . should the 80x80 icon be
> > 84x84?
> 
> Hi Fred,
> 
> If you've seen reference to 84, then that is a mistake.  There have never
> been icons shipped at 84.  The sizes should be 80/126/142/189/256/284 and we
> always shipped them in those sizes for 2.0.

Btw, technically there only needs to be 80/126/142/189/284.  The 256 size was just something Kevin asked for 'in case' it was needed.  Kevin, maybe you can explain the potential need for the 256 size.

Comment 11

[Kevin Grandon :kgrandon]

(In reply to Peter La from comment #9)
> (In reply to Fred Lin [:gasolin] from comment #7)
> > Hi I've seen several app use 84/126/142/189/284 instead of @2x.png style
> > 
> > The provided size are 80/126/142/189/256/284 . should the 80x80 icon be
> > 84x84?
> 
> Hi Fred,
> 
> If you've seen reference to 84, then that is a mistake.  There have never
> been icons shipped at 84.  The sizes should be 80/126/142/189/256/284 and we
> always shipped them in those sizes for 2.0.

I think that's wrong? 84 is expected and we support that for all of the apps. I am fairly certain we should be using 84px.

Comment 12

[Kevin Grandon :kgrandon]

The sizes we want here are as follows:

84
126
142
189
284

Comment 13

[Peter La]

Hey Kevin/Fred,

You guys are actually correct.  I got it mixed up, sorry. :(  Fred, so it is actually 84/126/142/189/284 like you said, but somehow I made the mistake of changing the @1 size to 80 when providing these new icons.  This was also the case for this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1038167

Will update with the correct size now in both bugs. :(

Comment 14

[Peter La]

Attachment: SearchResultsIcon-20140718.zip

Here are the Search Results icon with the proper @1 size of 84.

Sorry again for the mixup.

Comment 15

[[e-mail]]

Comment on attachment 8458446 [details] [review]
pull request redirect to github

updated 84x84 and run through png_recompress.sh

Comment 16

[Kevin Grandon :kgrandon]

Comment on attachment 8458446 [details] [review]
pull request redirect to github

Looks good to me, thanks!

Comment 17

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/7104d2996b9ad65d9fff57ada454699d3348f0a5

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/a0d41181eee099bd77b177ce15fa06d285b33219

Comment 19

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gecko     https://hg.mozilla.org/mozilla-central/rev/e9cdcf646d1c
BuildID   20140720160202
Version   33.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230

Gaia      bf3fb88039843359d0a5759b2c0fb787abae544f
Gecko     https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/590161396a0c
BuildID   20140722160201
Version   32.0
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230