1022550 - Downloads panel's icons look disabled in High Contrast mode

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Screenshot

The downloads panel uses icons (cancel, restart, open folder) that aren't very legible when using High Contrast mode. they should have higher contrast with the background. See attached screenshot.

Comment 1

[:Paolo Amadini]

Will be easier to fix once the icons are converted to SVG.

Comment 2

[Dão Gottwald [:dao]]

So bug 1289139 fixed the contrast, but by using graytext the icons now look disabled. This is more obvious in HC mode because that maps graytext to a very distinctive color (e.g. green whereas normal text would be yellow).

I'm morphing this bug to reflect that new reality.

Comment 3

[Dão Gottwald [:dao]]

Attachment: screenshot

Comment 4

[:Paolo Amadini]

Maybe we should restrict graytext to Mac and default Windows themes only, and use the normal field text color for all other themes?

Sean, Carol, can you help evaluate this bug?

Comment 5

[Dão Gottwald [:dao]]

You could also just use the normal text color across the board and slightly reduce the opacity except for non-default Windows.

Comment 6

[Sean Lee [:seanlee][:weilonge]]

Attachment: Bug 1022550 - Fix the color of action buttons in Downloads Panel to satisfy High Contrast mode.;

Review commit: https://reviewboard.mozilla.org/r/88912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88912/

Comment 7

[Sean Lee [:seanlee][:weilonge]]

Hi Dao,

Could you review the patch attachment 8805059 [details] ?
After discussing the color with Carol, using `color: initial` for action buttons is an acceptable and easy way to satisfy High Contrast mode.
The patch is verified in Windows 10, Ubuntu Linux, and MacOSX.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8805059 [details]
Bug 1022550 - Fix the color of action buttons in Downloads Panel to satisfy High Contrast mode.;

Did you mean 'inherit'? What color does 'initial' resolve to here?

Comment 9

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8805059 [details]
Bug 1022550 - Fix the color of action buttons in Downloads Panel to satisfy High Contrast mode.;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/88912/diff/1-2/

Comment 10

[Sean Lee [:seanlee][:weilonge]]

Sorry, it should be `inherit`, and it refers to the design of Dropmarker[1] in Downloads Panel. The patch has been updated.

[1] http://searchfox.org/mozilla-central/rev/4012e61cc38758ffa1f7ce26039173f67b048853/browser/themes/shared/downloads/downloads.inc.css#60

Comment 11

[:Paolo Amadini]

Comment on attachment 8805059 [details]
Bug 1022550 - Fix the color of action buttons in Downloads Panel to satisfy High Contrast mode.;

You definitely need to look for other rules that can now be removed because of this change. And I guess "inherit" is not the default here, and we need it for overriding platform styling, right?

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 8805059 [details]
Bug 1022550 - Fix the color of action buttons in Downloads Panel to satisfy High Contrast mode.;

Looks like this rule from downloads.inc.css should be redundant now:

+@item@[verdict="Malware"]:hover > .downloadButtonArea > .downloadButton {
+  color: inherit;
+}

Bug 1289139 also used graytext in allDownloadsViewOverlay.inc.css. Should probably fix that too.

Comment 13

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8805059 [details]
Bug 1022550 - Fix the color of action buttons in Downloads Panel to satisfy High Contrast mode.;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/88912/diff/2-3/

Comment 14

[Sean Lee [:seanlee][:weilonge]]

Hi Dao, please review this patch with the changes for downloads.inc.css and allDownloadsViewOverlay.inc.css. Thanks.

Comment 15

[Carsten Book [:Tomcat]]

need also review + and finished review in mozreview so we can use autolander to land this

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11c4b40810da
Fix the color of action buttons in Downloads Panel to satisfy High Contrast mode. r=dao

Comment 17

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/11c4b40810da

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Given that bug 1289139 landed on 52, can we consider uplifting this to Aurora?

Comment 19

[:Paolo Amadini]

Comment on attachment 8805059 [details]
Bug 1022550 - Fix the color of action buttons in Downloads Panel to satisfy High Contrast mode.;

(In reply to Ryan VanderMeulen [:RyanVM] from comment #18)
> Given that bug 1289139 landed on 52, can we consider uplifting this to
> Aurora?

We should!

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1289139
[User impact if declined]: The color of download buttons in high contrast themes would be visible, but would look like a disabled button.
[Is this code covered by automated tests?]: No, we don't test front-end CSS
[Has the fix been verified in Nightly?]: Looks like QE hasn't manually verified the fix yet
[Needs manual test from QE? If yes, steps to reproduce]: In a sentence, run a download in high contrast mode and check the color of the action button.
[List of other uplifts needed for the feature/fix]: None that are specifically related to this bug, we may need more uplifts for the feature later
[Is the change risky?]: Limited risk
[Why is the change risky/not risky?]: The CSS rules touched here are only used by this part of the UI
[String changes made/needed]: None

Comment 20

[:Paolo Amadini]

To clarify, the fix is for download action buttons inside the Downloads Panel.

Comment 21

[Julien Cristau [:jcristau]]

Comment on attachment 8805059 [details]
Bug 1022550 - Fix the color of action buttons in Downloads Panel to satisfy High Contrast mode.;

fix download panel buttons vs high contrast mode interaction, for aurora52

Comment 22

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/279134247633

Comment 23

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 32.0a1 (2014.06.09) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 52.0a2 (2017.01.18) and Firefox 53.0a1 (2017.01.17) on Win 8.1 x64.