1022563 - Don't use --enable-trace-malloc on SeaMonkey debug desktop tinderbox builds

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Philip Chee]

+++ This bug was initially created as a clone of Bug #1013014 +++
> On TBPL, debug desktop builds are built with --enable-trace-malloc. This means 
> they don't use jemalloc, because TraceMalloc is incompatible with jemalloc. But 
> as far as I know, the TraceMalloc enabling serves no purpose, other than perhaps 
> to provide compile coverage.

See also Thunderbird Bug 1022449

Comment 1

[Edmund Wong (:ewong)]

Attachment: removed --enable-trace-malloc option from debug mozconfigs.(v1)

Comment 2

[Edmund Wong (:ewong)]

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/6a8f85bc2880

Comment 3

[Nicholas Nethercote [inactive]]

Bug 1018039 might also be relevant.

Comment 4

[Edmund Wong (:ewong)]

(In reply to Nicholas Nethercote [:njn] from comment #3)
> Bug 1018039 might also be relevant.

Do we need to add --enable-dmd on our builders?

Comment 5

[Edmund Wong (:ewong)]

Comment on attachment 8436825 [details] [diff] [review]
removed --enable-trace-malloc option from debug mozconfigs.(v1)

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: no windows build.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 6

[Edmund Wong (:ewong)]

Pushed to comm-beta:
 https://hg.mozilla.org/releases/comm-beta/rev/9e0bc6702db2

Comment 7

[Edmund Wong (:ewong)]

Comment on attachment 8436825 [details] [diff] [review]
removed --enable-trace-malloc option from debug mozconfigs.(v1)

It's already in comm-aurora(due to uplift) and comm-central.

Comment 8

[Edmund Wong (:ewong)]

Comment on attachment 8436825 [details] [diff] [review]
removed --enable-trace-malloc option from debug mozconfigs.(v1)

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: debug builds fail.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 9

[Edmund Wong (:ewong)]

Pushed to comm-release:
 https://hg.mozilla.org/releases/comm-release/rev/f29497549d0e

Comment 10

[Edmund Wong (:ewong)]

All three trees have this pushed.  c-c (and c-a from uplift), c-b and recently
c-r.

Closing