102257 - Printing crashes if all the print.printt(header|footer)* prefs are empty strings

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Boris Zbarsky [:bzbarsky]]

When I set the preferences like this:

user_pref("print.print_footerleft", "");
user_pref("print.print_footercenter", "");
user_pref("print.print_footerright", "");
user_pref("print.print_headerleft", "");
user_pref("print.print_headercenter", "");
user_pref("print.print_headerright", "");

Printing crashes.  spun off of bug 99415

Comment 1

[sujay]

is this the same as 102247 ? please DUP them if they are...thanks.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: patch to fix this

Comment 3

[Boris Zbarsky [:bzbarsky]]

*** Bug 102247 has been marked as a duplicate of this bug. ***

Comment 4

[Boris Zbarsky [:bzbarsky]]

reviews?

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 51299 [details] [diff] [review]
patch to fix this

sr=shaver

Comment 6

[rods (gone)]

It's always something.... :)
r=rods

Comment 7

[rods (gone)]

taking bug

Comment 8

[Boris Zbarsky [:bzbarsky]]

Rod, will you be checking this in then?  Or should I?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Checked in

Comment 10

[sujay]

Boris, please verify on trunk when you get chance....

Comment 11

[Boris Zbarsky [:bzbarsky]]

verified on current trunk.  I don't crash anymore.

Comment 12

[Judson Valeski]

please checkin to the 0.9.4 branch and mark w/ "fixed0.9.4" once it's landed
there. This is a low risk change w/ some good benefit.

Comment 13

[Michael Dunn]

When is this landing.

Comment 14

[Boris Zbarsky [:bzbarsky]]

as soon as someone with a 0.9.4 tree lands it...  I do not have such a tree.

Comment 15

[Chak Nanga]

Patch checked into the 0.9.4 branch now...

Comment 16

[sujay]

verified on 1/13 branch build.