Closed Bug 1022587 Opened 7 years ago Closed 7 years ago

Kill reference to this._tabActor.browser in CSS Coverage

Categories

(DevTools :: Style Editor, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

Attachments

(1 file)

Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #8446002 - Flags: review?(paul)
Joe, can you explain why you need progress listener? What about using the "load" event on the window?

Also - what kind of "load" event do you want? As in: your initial code (browser.addEventListener("load")) would be called for any load event within the page, not just the load event of the top window. Is it the behavior you want?
(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #2)
> Joe, can you explain why you need progress listener? What about using the
> "load" event on the window?

2 problems:

* How do you attach a listener in time?
* "load" events don't propagate through frames

> Also - what kind of "load" event do you want? As in: your initial code
> (browser.addEventListener("load")) would be called for any load event within
> the page, not just the load event of the top window. Is it the behavior you
> want?

I want to be notified when any frame loads, exactly like the browser load event. I get that at the moment with status(stop/window) - i.e. I'm filtering out CSS/JS/image/etc load events.
(In reply to Joe Walker [:jwalker] from comment #3)
> (In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from
> comment #2)
> > Joe, can you explain why you need progress listener? What about using the
> > "load" event on the window?
> 
> 2 problems:
> 
> * How do you attach a listener in time?

tabActor.window.addEventListener() ?

> * "load" events don't propagate through frames

Indeed, that's a problem. load events are not propagated through docshells if you don't use the browser tag.

> > Also - what kind of "load" event do you want? As in: your initial code
> > (browser.addEventListener("load")) would be called for any load event within
> > the page, not just the load event of the top window. Is it the behavior you
> > want?
> 
> I want to be notified when any frame loads, exactly like the browser load
> event. I get that at the moment with status(stop/window) - i.e. I'm
> filtering out CSS/JS/image/etc load events.

Understood.
Attachment #8446002 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/f6cee8c74faf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.