1022587 - Kill reference to this._tabActor.browser in CSS Coverage

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Description

[Joe Walker [:jwalker]]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1016330#c2

Comment 1

[Joe Walker [:jwalker]]

Attachment: 0003-Bug-1022587-Kill-reference-to-this._tabActor.browser.patch

Comment 2

[Paul Rouget [:paul]]

Joe, can you explain why you need progress listener? What about using the "load" event on the window?

Also - what kind of "load" event do you want? As in: your initial code (browser.addEventListener("load")) would be called for any load event within the page, not just the load event of the top window. Is it the behavior you want?

Comment 3

[Joe Walker [:jwalker]]

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #2)
> Joe, can you explain why you need progress listener? What about using the
> "load" event on the window?

2 problems:

* How do you attach a listener in time?
* "load" events don't propagate through frames

> Also - what kind of "load" event do you want? As in: your initial code
> (browser.addEventListener("load")) would be called for any load event within
> the page, not just the load event of the top window. Is it the behavior you
> want?

I want to be notified when any frame loads, exactly like the browser load event. I get that at the moment with status(stop/window) - i.e. I'm filtering out CSS/JS/image/etc load events.

Comment 4

[Paul Rouget [:paul]]

(In reply to Joe Walker [:jwalker] from comment #3)
> (In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from
> comment #2)
> > Joe, can you explain why you need progress listener? What about using the
> > "load" event on the window?
> 
> 2 problems:
> 
> * How do you attach a listener in time?

tabActor.window.addEventListener() ?

> * "load" events don't propagate through frames

Indeed, that's a problem. load events are not propagated through docshells if you don't use the browser tag.

> > Also - what kind of "load" event do you want? As in: your initial code
> > (browser.addEventListener("load")) would be called for any load event within
> > the page, not just the load event of the top window. Is it the behavior you
> > want?
> 
> I want to be notified when any frame loads, exactly like the browser load
> event. I get that at the moment with status(stop/window) - i.e. I'm
> filtering out CSS/JS/image/etc load events.

Understood.

Comment 5

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=f6cee8c74faf
https://hg.mozilla.org/integration/fx-team/rev/f6cee8c74faf

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f6cee8c74faf