Closed
Bug 1022587
Opened 10 years ago
Closed 10 years ago
Kill reference to this._tabActor.browser in CSS Coverage
Categories
(DevTools :: Style Editor, defect)
DevTools
Style Editor
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: jwalker, Assigned: jwalker)
References
Details
Attachments
(1 file)
3.04 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•10 years ago
|
Blocks: enable-csscoverage
Assignee | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Joe, can you explain why you need progress listener? What about using the "load" event on the window? Also - what kind of "load" event do you want? As in: your initial code (browser.addEventListener("load")) would be called for any load event within the page, not just the load event of the top window. Is it the behavior you want?
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #2) > Joe, can you explain why you need progress listener? What about using the > "load" event on the window? 2 problems: * How do you attach a listener in time? * "load" events don't propagate through frames > Also - what kind of "load" event do you want? As in: your initial code > (browser.addEventListener("load")) would be called for any load event within > the page, not just the load event of the top window. Is it the behavior you > want? I want to be notified when any frame loads, exactly like the browser load event. I get that at the moment with status(stop/window) - i.e. I'm filtering out CSS/JS/image/etc load events.
Comment 4•10 years ago
|
||
(In reply to Joe Walker [:jwalker] from comment #3) > (In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from > comment #2) > > Joe, can you explain why you need progress listener? What about using the > > "load" event on the window? > > 2 problems: > > * How do you attach a listener in time? tabActor.window.addEventListener() ? > * "load" events don't propagate through frames Indeed, that's a problem. load events are not propagated through docshells if you don't use the browser tag. > > Also - what kind of "load" event do you want? As in: your initial code > > (browser.addEventListener("load")) would be called for any load event within > > the page, not just the load event of the top window. Is it the behavior you > > want? > > I want to be notified when any frame loads, exactly like the browser load > event. I get that at the moment with status(stop/window) - i.e. I'm > filtering out CSS/JS/image/etc load events. Understood.
Updated•10 years ago
|
Attachment #8446002 -
Flags: review?(paul) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Fx-Team&rev=f6cee8c74faf https://hg.mozilla.org/integration/fx-team/rev/f6cee8c74faf
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f6cee8c74faf
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•