1022616 - gen_template.pl generates busted chrome tests because its path to SimpleTest is wrong

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[:Gijs (he/him)]

Existing tests use:

chrome://mochikit/content/tests/SimpleTest/SimpleTest.js

but the template ( http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/static/xul.template.txt ) generates:

9   <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"/>

which 404s.

Comment 1

[:Gijs (he/him)]

Attachment: mochitest chrome template uses broken path to SimpleTest.js,

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8436893 [details] [diff] [review]
mochitest chrome template uses broken path to SimpleTest.js,

Review of attachment 8436893 [details] [diff] [review]:
-----------------------------------------------------------------

thanks. on an unrelated note, do people still use these templates?  I was under the impression it was more of a copy/paste from a similar test.

Comment 3

[(not currently active) Ted Mielczarek]

I don't think I've ever used one of these templates, they're clearly not well-supported.

Comment 4

[(not currently active) Ted Mielczarek]

I think we'd be better-served just having a simple example test of each kind that developers could copy and paste. Having them be real example tests means they'd be actually run in production and would be up-to-date by necessity.

Comment 5

[:Gijs (he/him)]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> I think we'd be better-served just having a simple example test of each kind
> that developers could copy and paste. Having them be real example tests
> means they'd be actually run in production and would be up-to-date by
> necessity.

I would agree, but right now, this is still the recommended way (per docs) of creating new tests.

I'd like to just land this, and file a followup bug to add simple sample tests, and a mach command to do what gen_template.pl does now based on those sample tests. I don't know if/when I will have time to do that, though.

Does that sound OK?

Comment 6

[(not currently active) Ted Mielczarek]

That's fine. No point in blocking an already-written patch on a better solution.

Comment 7

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/c0a859335b41

Comment 8

[:Gijs (he/him)]

Filed bug 1022683.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c0a859335b41