1022618 - test_gallery_crop_photo is incorrectly asserting

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[Zac C (:zac)]

The test_gallery_crop_photo is using assertLess to compare two strings.

This should be resolved to compare numbers or the assert changed entirely to assert that the image has been cropped.

Comment 1

[Dylan Chun Wong [:dwong]]

I think I've come up with a solution for now by comparing the rendered areas of the images. As it's cropping a landscape photo to a portrait on a portrait phone the rendered area should increase as the rendered height is increased to fit the image. Though it might be too fragile as choosing different crop settings or images could break it. Is there an easy way to get the actual image heights and widths?

Comment 2

[Dylan Chun Wong [:dwong]]

Attachment: Proposed pr that adjusts assert to compare rendered image area

Comment 3

[Zac C (:zac)]

Comment on attachment 8437818 [details] [review]
Proposed pr that adjusts assert to compare rendered image area

I think your hunch is correct that just looking at the size could be unreliable.

It might be safer just to return the scale as an [x, y] tuple which can then be asserted.

Comment 4

[Dylan Chun Wong [:dwong]]

Thanks Zac, I'll look into it, though I will wait on the status of Bug 1023305 as it seems to attempt to address the issue as well

Comment 5

[Dylan Chun Wong [:dwong]]

I came back to this since I realized the 1.4 crop assert was a separate issue. But would you prefer just doing an assert less directly on the list/tuple or comparing them elementwise? It seems the scale's x, y properties x==y always.

Comment 6

[Dylan Chun Wong [:dwong]]

Attachment: New PR adjusting current_scale to return a list of floats to represent scale x,y isntead of string

Erm, I forget that Python compares it elementwise anyways. Here is the new pull with the changes you asked for.

Comment 7

[[:AndreiH]]

Comment on attachment 8440161 [details] [review]
New PR adjusting current_scale to return a list of floats to represent scale x,y isntead of string

I am going to give this an r+

Comment 8

[Zac C (:zac)]

Comment on attachment 8440161 [details] [review]
New PR adjusting current_scale to return a list of floats to represent scale x,y isntead of string

r+ thanks Dylan, sorry about the delay in reviewing it!

Comment 9

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/32c6a65f74ecf7d5d2d33c09fe2e85d31200a5b0