Closed Bug 1022633 Opened 10 years ago Closed 10 years ago

Branding file path is broken in DEBUG=1 mode

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ochameau, Assigned: ochameau)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
We can see an exception during firefox startup when using a DEBUG=1 profile.

1401093991993	addons.xpi	WARN	Exception running bootstrap method startup on httpd@gaiamobile.org: [Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsILocalFile.initWithPath]"  nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm -> file:///home/alex/gaia/profile-debug/extensions/httpd/bootstrap.js :: startupHttpd :: line 137"  data: no] Stack trace: startupHttpd()@resource://gre/modules/addons/XPIProvider.jsm -> file:///home/alex/gaia/profile-debug/extensions/httpd/bootstrap.js:137 < startup()@resource://gre/modules/addons/XPIProvider.jsm -> file:///home/alex/gaia/profile-debug/extensions/httpd/bootstrap.js:450 < XPI_callBootstrapMethod()@resource://gre/modules/addons/XPIProvider.jsm:4274 < XPI_startup()@resource://gre/modules/addons/XPIProvider.jsm:1956 < AMI_callProviders()@resource://gre/modules/AddonManager.jsm:870 < AMI_startup()@resource://gre/modules/AddonManager.jsm:746 < AMP_startup()@resource://gre/modules/AddonManager.jsm:2313 < AMC_observe()@resource://gre/components/addonManager.js:55 < <file:unknown>
############################### browserElementPanning.js loaded

The branding folder seems to have been moved from /shared/branding to /shared/resources/branding, that, without updating httpd sourcecode. (One more reason to work on bug 973786)
Assignee: nobody → poirot.alex
Attached file patch
Attachment #8436918 - Flags: review?(yurenju.mozilla)
(One visible breakage is that we don't see the red square Mozilla logo on startup)
Comment on attachment 8436918 [details] [review]
patch

thanks! r=yurenju
Attachment #8436918 - Flags: review?(yurenju.mozilla) → review+
master:
https://github.com/mozilla-b2g/gaia/commit/99695e03c7603ca32f4b679d32e736b496823c8c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: