Closed
Bug 1022638
Opened 11 years ago
Closed 11 years ago
Remove tools logos from navigation bar
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cassie, Assigned: Tanay, Mentored)
Details
(Whiteboard: [good first bug])
Attachments
(2 files, 1 obsolete file)
tools-nav.png
Having the tools logos in the navigation looks a little janky. Would prefer to simplify this – remove the images and just have the tools names, so that the navigation is all text links.
|
||
Updated•11 years ago
|
Mentor: kate
Whiteboard: [good first bug][mentor=kate] → [good first bug]
|
||
Comment 1•11 years ago
|
||
Are you talking about the tools page specifically ( https://webmaker.org/en-US/tools ) or the whole navigation ?
Flags: needinfo?(cassie)
Hi, I am computing student and would like to work on this could you assign me this bug so I can fix it?
|
|
Reporter | |
Comment 3•11 years ago
|
||
I'm talking about this area in the sub-navigation on /Tools. We should remove the logos and have them spaced exactly like the other subnav, which is text only.
Flags: needinfo?(cassie)
|
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → mustafa_adam1990
|
Assignee | |
Comment 4•11 years ago
|
||
Are the icons dependent only on navigation.json file?
|
|
Assignee | |
Updated•11 years ago
|
Flags: needinfo?(kate)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Having an issue, the appmaker icon is not there in the navigation.json file. Since it uses angular's ng-if for icons, will removing icon entry from the json file would be enough? Please advise!
|
|
||
Comment 6•11 years ago
|
||
I think since tools was the only place that uses icons, we should just remove that part of the template altogether, including all references to icons for the tools pages.
Flags: needinfo?(kate)
|
|
Assignee | |
Comment 7•11 years ago
|
||
Attachment #8459671 -
Flags: review?(kate)
|
|
Assignee | |
Comment 8•11 years ago
|
||
Comment on attachment 8459671 [details] [diff] [review]
https://github.com/mozilla/webmaker.org/pull/898
https://github.com/mozilla/webmaker.org/pull/898
Attachment #8459671 -
Attachment description: https://github.com/mozilla/webmaker.org/pull/895 → https://github.com/mozilla/webmaker.org/pull/898
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8459671 -
Attachment is patch: true
Attachment #8459671 -
Attachment mime type: text/x-github-pull-request → text/plain
|
|
||
Comment 9•11 years ago
|
||
Attachment #8459671 -
Attachment is obsolete: true
Attachment #8459671 -
Flags: review?(kate)
Attachment #8460311 -
Flags: review?(kate)
|
|
||
Comment 10•11 years ago
|
||
Comment on attachment 8460311 [details] [review]
https://github.com/mozilla/webmaker.org/pull/898
Just need to add this to the angular page as well, sorry again for the duplication
Attachment #8460311 -
Flags: review?(kate) → review-
|
|
||
Updated•11 years ago
|
Assignee: kate → tanay1337
|
|
||
Comment 11•11 years ago
|
||
Comment on attachment 8460311 [details] [review]
https://github.com/mozilla/webmaker.org/pull/898
Nice!
Attachment #8460311 -
Flags: review- → review+
|
||
Comment 12•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/13014c0fa2bcfce87e658a8f4e34e44fe2c5077d
Fixed Bug 1022638
Removed tools logos from navigation bar
https://github.com/mozilla/webmaker.org/commit/cd663927419d64b56554a985b241a544af22e6ae
Fixed Bug 1022638
Made changes in this parallel file.
https://github.com/mozilla/webmaker.org/commit/34bbb255d42f83e1fcbab87f1e70049d571f1463
Merge pull request #898 from tanay1337/Bug-1022638
Fixed Bug 1022638
|
|
||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•