1022720 - mozregression should use mozversion

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[William Lachance (:wlach)]

Right now we use some custom code inside mozregression to get version information:

https://github.com/mozilla/mozregression/blob/master/mozregression/runnightly.py#L168
https://github.com/mozilla/mozregression/blob/master/mozregression/runnightly.py#L271
https://github.com/mozilla/mozregression/blob/master/mozregression/runnightly.py#L327

We should just use mozversion for this. This will also help with getting gaia version information once we land bug 943485.

Comment 1

[Julien Pagès (:parkouss)]

I started to look at this, and it seems that mozversion handles fennec in mozilla-central [1], but not on the pypi latest version (currently 0.4) [2].

This means that I cannot use mozversion dependency properly in the setup.py - and cannot currently use mozversion for fennec in mozregression.

Is it possible to release a mozversion with fennec support ? A new mozversion-0.5 properly distributed on pypi will probably resolve this - I will then use a dependency "mozversion >= 0.5" in mozregression.

[1] http://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozversion/mozversion/mozversion.py#238

[2] https://pypi.python.org/pypi/mozversion/0.4

Comment 2

[William Lachance (:wlach)]

(In reply to j.parkouss from comment #1)
> I started to look at this, and it seems that mozversion handles fennec in
> mozilla-central [1], but not on the pypi latest version (currently 0.4) [2].
> 
> This means that I cannot use mozversion dependency properly in the setup.py
> - and cannot currently use mozversion for fennec in mozregression.
> 
> Is it possible to release a mozversion with fennec support ? A new
> mozversion-0.5 properly distributed on pypi will probably resolve this - I
> will then use a dependency "mozversion >= 0.5" in mozregression.
> 
> [1]
> http://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozversion/
> mozversion/mozversion.py#238
> 
> [2] https://pypi.python.org/pypi/mozversion/0.4

Oops, yes, we bumped the version but I forgot to release to pypi after it merged. Fixed:

https://pypi.python.org/pypi/mozversion

Comment 3

[William Lachance (:wlach)]

Assigning this to j.parkouss for now, assuming he wants it.

Comment 4

[Julien Pagès (:parkouss)]

(In reply to William Lachance (:wlach) from comment #3)
> Assigning this to j.parkouss for now, assuming he wants it.

Sure :) I already started to work on this ([1]) but I'm waiting bug 943485 to make a pull request.

[1] https://github.com/parkouss/mozregression/compare/master...1022720_use_mozversion

Comment 5

[William Lachance (:wlach)]

(In reply to j.parkouss from comment #4)
> (In reply to William Lachance (:wlach) from comment #3)
> > Assigning this to j.parkouss for now, assuming he wants it.
> 
> Sure :) I already started to work on this ([1]) but I'm waiting bug 943485
> to make a pull request.
> 
> [1]
> https://github.com/parkouss/mozregression/compare/master...
> 1022720_use_mozversion

Ok cool! Sorry for the delay, will merge things in tomorrow. You can always commit your changes to your fork in the mean time.

Comment 6

[Julien Pagès (:parkouss)]

I made a pull request. :)

About gaia version, I think it is 'gaia_changeset' and 'gaia_date' keys from the info that you want. And I suppose that we need to display it along with application changeset/date.

Am I right ?

Comment 7

[William Lachance (:wlach)]

(In reply to j.parkouss from comment #6)
> I made a pull request. :)

Cool, I will look at it on Monday. In the future, could you flag pull requests for review as specified here:

http://globau.wordpress.com/2013/10/21/github-pull-requests-and-bugzilla/

That'll make sure it gets on my queue. 

> About gaia version, I think it is 'gaia_changeset' and 'gaia_date' keys from
> the info that you want. And I suppose that we need to display it along with
> application changeset/date.
> 
> Am I right ?

It's really the changeset that we care about, more than anything else. What we want to do is be able to give a URL that narrows done the gaia regression range. Something like this:

https://github.com/mozilla-b2g/gaia/compare/63ea1f10362fe6ef4ac8de7b7f93e6fdf61ef20b...458b007252aadbc871253b020af398dbd0dbdbb1

That way we can narrow down which specific commit(s) were likely responsible for the regression.

Comment 8

[Julien Pagès (:parkouss)]

Attachment: [mozregression] make use of mozversion to get application infos

Comment 9

[William Lachance (:wlach)]

Comment on attachment 8441331 [details] [review]
[mozregression] make use of mozversion to get application infos

Looks good, thanks! Applied.