1022733 - Entry points lost their splash screen/overlay icons

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Etienne Segonzac (:etienne)]

It's a pretty recent regression. But everything works find on the homescreen.

Comment 1

[Etienne Segonzac (:etienne)]

Reverting bug 1020903 fixes the issue.
Can you take a look Fredrik?

The Dialer and Contacts app are different entry points of the same app and it looks like we were using the code path you changed to handle this.

Comment 2

[Fredrik Lanker [:lanker]]

In this case, the launch_path is included in the origin too, so the URI for the splash icon ends up incorrect. I think I'll make a fix that parses the origin to get the "real origin".

Comment 3

[Fredrik Lanker [:lanker]]

Attachment: Bug 1022733 - Entry points lost their splash screen/overlay icons

The reason for doing it like this instead of handling the port issue in the original code (prior to the fix in bug 1020903) is that we want to support having basic authentication in the URI too. I haven't found a way to do that without parsing the URI like this.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8437547 [details] [review]
Bug 1022733 - Entry points lost their splash screen/overlay icons

r+ but please make unit test next time.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/16e7d20ca582c0e830ba4b311aad3cd5e3aabf97

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/5cd363cfb8a4feffe24b73b63f005c4a8a54238e

Comment 8

[Lancy(Leave from Mozilla)]

Hi Etienne,

Could you please provide the detailed reproduce steps or video for me to verify this bug?
Thank you very much!

Comment 9

[Etienne Segonzac (:etienne)]

STR:
- kill all apps
- launch the Phone app
- During the opening animation we should see the "phone" icon on a black background, not just a black background.

Comment 10

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.0 & 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0

Flame v2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0