Closed
Bug 1022780
Opened 10 years ago
Closed 10 years ago
Cmd+H triggers 'hide markup', should only be triggered by H
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: canuckistani, Assigned: bgrins)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.58 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
As reported here: https://ffdevtools.uservoice.com/forums/246087-firefox-developer-tools-ideas/suggestions/6025843-use-a-different-shortcut-to-hide-markup-cmd-h-i "I hide Firefox 100s of times per day but in many instances, the CMD + H shortcut hides currently selected markup instead of actually hiding the app (when dev tools are open - I'm on OSX 10.9.3). A minor annoyance unless you're a person that hates reaching for the mouse - especially to fix a shortcut error!"
|
Assignee | |
Comment 1•10 years ago
|
||
The hiding works with just 'H', so we should not run it if with cmd/ctrl is pressed to prevent this issue
|
|
Assignee | |
Updated•10 years ago
|
Summary: Cmd+H triggers 'hide markup', should only be trigger by CM+Shift+H → Cmd+H triggers 'hide markup', should only be triggered by H
|
|
Assignee | |
Comment 2•10 years ago
|
||
What do you think?
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8440706 [details] [diff] [review] hidenode.patch Review of attachment 8440706 [details] [diff] [review]: ----------------------------------------------------------------- Looks good enough to me.
Attachment #8440706 -
Flags: review?(pbrosset) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=1589b62fd340
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e68ae95a9caf Friendly reminder that your commit message should be summarizing what the patch is doing, not restating the problem it's fixing. Thanks :) https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e68ae95a9caf
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•