Closed Bug 1022785 Opened 6 years ago Closed 6 years ago

disable android snippets for reftests/crashtests/jsreftests

Categories

(Testing :: General, defect)

defect
Not set

Tracking

(firefox31 fixed, firefox32 fixed, firefox33 fixed, firefox-esr24 fixed, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
mozilla33
Tracking Status
firefox31 --- fixed
firefox32 --- fixed
firefox33 --- fixed
firefox-esr24 --- fixed
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

No description provided.
We already do this for mochitests, let's do it for our other suites, too!

http://mxr.mozilla.org/mozilla-central/source/testing/profiles/prefs_general.js#171
Attachment #8437056 - Flags: review?(jmaher)
Blocks: 995417
froydnj++
Comment on attachment 8437056 [details] [diff] [review]
disable android snippets for reftests/crashtests/jsreftests

Review of attachment 8437056 [details] [diff] [review]:
-----------------------------------------------------------------

should we do this for talos as well?
Attachment #8437056 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #3)
> should we do this for talos as well?

A lot of these pref settings that have been going in in service of bug 995417 should probably be ported over to talos as well, along with the eventual no-external-network environment variable setting.  But I've been focusing on mochi/ref/crash/etc. tests because those are the bulk of the tests.  Talos should be a lot easier after getting those tests in order!
Assignee: nobody → nfroyd
https://hg.mozilla.org/mozilla-central/rev/963317561547
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
I'm going to mark this as [qa-] as this will be difficult to test locally. However, I looked over the patch in comment #3 and ensured:

js/src/tests/user.js
-> user_pref("browser.snippets.enabled", false);
-> user_pref("browser.snippets.syncPromo.enabled", false);

layout/tools/reftest/runreftest.py
-> prefs['browser.snippets.enabled'] = False
-> refs['browser.snippets.syncPromo.enabled'] = False

If someone has a way of testing this locally or knows of any test cases that could be used in this instance, please comment :)
Status: RESOLVED → VERIFIED
Whiteboard: [qa-]
Status: VERIFIED → RESOLVED
Closed: 6 years ago6 years ago
Depends on: 1036028
You need to log in before you can comment on or make changes to this bug.