Closed Bug 1022809 Opened 10 years ago Closed 10 years ago

[Camera] Remove lazy_loader.js script tag

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S4 (20june)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: justindarc, Assigned: justindarc)

Details

(Keywords: perf, Whiteboard: [c=startup p= s= u=])

Attachments

(2 files)

pull-request (master)
46 bytes, text/x-github-pull-request
dmarcos
: review+
hkoka
: approval-gaia-v2.0+
Details | Review
pull-request (v2.0)
46 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review 
lazy_loader.js is no longer used. There is a <script defer> tag for it that is likely introducing a bit of startup time.
Attached file pull-request (master) — 

        Attachment #8437080 -
        Flags: review?(dmarcos)

        Attachment #8437080 -
        Flags: review?(dmarcos) → review+
Keywords: perf
Whiteboard: [c=startup p= s= u=]

    
    

    
  
If bug 1014955 lands on 1.4, we should also uplift this since it improves start up time. Noming for 1.4.
blocking-b2g: --- → 1.4?
Depends on: 1014955

    
    

    
  
mchang: I already included that fix in my uplift patch for 1014955 for v1.4 (it was just one line in index.html that was supposed to have been removed a long time ago -- likely a merge conflict error)
blocking-b2g: 1.4? → ---

    
  
No longer depends on: 1014955

    
    

    
  
Landed on master:

https://github.com/mozilla-b2g/gaia/commit/a16d0750231eb1acb5b28c89de2c367bfc1792ff

Needs uplift to v2.0 (setting NI? for djf)
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(dflanagan)
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8437080 [details] [review]
pull-request (master)



Approving for perf (start-up time) improvement

        Attachment #8437080 -
        Flags: approval-gaia-v2.0+

    
    

    
  

      
      
      
      

        Attached file
          
        pull-request (v2.0)
        — 
      

    


  
Pull request for v2.0 -- Carrying R+ forward

        Attachment #8437824 -
        Flags: review+

    
    

    
  
Landed on v2.0:

https://github.com/mozilla-b2g/gaia/commit/b4cdfc1daa7077b9b04ee722a20d3b1e6c9fbea7

Clearing NI? for djf, approved v2.0+ from hema
Flags: needinfo?(dflanagan)
Assignee: nobody → jdarcangelo

          status-b2g-v2.0:
          --- → fixed

          status-b2g-v2.1:
          --- → fixed
Target Milestone: --- → 2.0 S4 (20june)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: