Closed Bug 1022821 Opened 6 years ago Closed 6 years ago

Stop returning RefPtr and, where not an out-param, stop using RefPtr arguments

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(3 files)

Stop returning RefPtr and, where not an out-param, stop passing RefPtr.
Attached patch Moz2D separatelySplinter Review
Attachment #8437093 - Flags: review?(bas)
Attachment #8437093 - Flags: review?(bas) → review?(bgirard)
Attachment #8437093 - Flags: review?(bgirard) → review+
Attached patch contentSplinter Review
Attachment #8437120 - Flags: a11y-review?(gwright)
Attachment #8437120 - Flags: a11y-review?(gwright) → review?(gwright)
Summary: Stop returning RefPtr and, where not an out-param, stop passing RefPtr → Stop returning RefPtr and, where not an out-param, stop using RefPtr arguments
Attached patch gfxSplinter Review
Attachment #8437126 - Flags: review?(vladimir)
Keywords: leave-open
Comment on attachment 8437126 [details] [diff] [review]
gfx

Review of attachment 8437126 [details] [diff] [review]:
-----------------------------------------------------------------

Fly-by review, LGTM but if you want to wait for Vlad that's fine.
Attachment #8437126 - Flags: review+
Comment on attachment 8437126 [details] [diff] [review]
gfx

Nah, I only asked vlad because he looked at this briefly when I mentioned it on IRC. I'm sure he has better things to do than provide a second review of this though.

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd50c7187a48
Attachment #8437126 - Flags: review?(vladimir)
Attachment #8437126 - Flags: checkin+
I use Try a lot FWIW, but there's a traid-off to be made. Yesterday was a know single test "may need increased fuzz" which could be added without disrupting anyone, which I warned you about it, and stuck around to add that fuzz on the one platform that needed it. Given that I've pushed 30 patches in the last 7 days this bounce makes a 1-to-30 bounce rate which I think is a good tradeoff, especially since the tree is dead quiet right now.
Relanded with the fix to the gfx widget function:

https://hg.mozilla.org/integration/mozilla-inbound/rev/419c91a784bc
Attachment #8437120 - Flags: review?(gwright) → review+
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/101967b0537d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.