1022848 - [B2G][Browser] User cannot unbookmark a page in the broswer app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Description:
When the user long taps on one of the preloaded bookmarks in browser (ex. http://mozilla.org) the menu will show, but none of the options are responsive except 'cancel'.

Prerequisites: Be connected to wifi

Repro Steps:
1) Update a Flame to BuildID: 20140609040203
2) Open Browser App> Tap on tab in top right> Tap on '+'
3) Select bookmarks from the tabs at the top
4) Long press on one of the preloaded bookmarks

Actual:
The menu that pops up for the bookmark is unresponsive

Expected:
The menu buttons respond properly when tapped

Flame 2.0

Environmental Variables:
Device: Flame 2.0
Build ID: 20140609040203
Gaia: 12af93123c5db55212d51fe235d39f21209a1eaa
Gecko: 9305a8ec77fe
Version: 32.0a1 (2.0) 
Firmware Version: v10G-2

User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Keywords: SIM, Options, Menu, Items, Tap, Press, Long, Activate

Notes:If the user adds a custom bookmark and then tries to repro this bug, they will hit this bug instead: https://bugzilla.mozilla.org/show_bug.cgi?id=900703

Repro frequency: 100%
Link to failed test case:
See attached: Logcat, Video - https://www.youtube.com/watch?edit=vd&v=bzBDrj0onyw

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue does NOT occur in Flame 1.4

Flame 1.4

1.4F Environmental Variables:
Device: Flame 1.4F
BuildID: 20140606040202
Gaia: 0c16adced7c51f795ef250aebe184f60b6a9b987
Gecko: 04216748e6c1
Version: 30.0
Firmware Version: v10G-2
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

The menu appears with only the option to unbookmark something. Tapping on 'Unbookmark' does unbookmark a bookmark

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Flame 2.0 Logcat

This logcat may be affected by bug https://bugzilla.mozilla.org/show_bug.cgi?id=1010993

Comment 3

[Lionel Mauritson]

B2G Inbound

Last Working
Device: Flame
BuildID: 20140606084657
Gaia: d98df93b7d4c060f19fc8bb0b1238a70012af15e
Gecko: 7d733b5e6ab9
Version: 32.0a1 (2.0) 
Firmware Version: v10G-2

First Broken
Device: Flame
BuildID: 20140606091835
Gaia: dbd4e40dd86d0af6bf69a6bb8babee8a5e226be4
Gecko: e0e3f8704c85
Version: 32.0a1 (2.0) 
Firmware Version: v10G-2

First Broken's Gaia, Last Working's Gecko: Issue DOES reproduce.
Gaia: dbd4e40dd86d0af6bf69a6bb8babee8a5e226be4
Gecko: 7d733b5e6ab9

Last Working's Gaia, First Broken's Gecko: Issue does NOT reproduce.
Gaia: d98df93b7d4c060f19fc8bb0b1238a70012af15e
Gecko: e0e3f8704c85

Determined to be a Gaia issue.
Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/d98df93b7d4c060f19fc8bb0b1238a70012af15e...dbd4e40dd86d0af6bf69a6bb8babee8a5e226be4

Comment 4

[Jason Smith [:jsmith]]

Broken by bug 1020685.

Kyle - Any ideas?

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

That's impressive.  Let's go ahead and back out.

Comment 6

[Jason Smith [:jsmith]]

Ben - Can you backout bug 1020685?

Comment 7

[Ben Francis [:benfrancis]]

Reverted by https://github.com/mozilla-b2g/gaia/commit/28e9b207fa9a6f42ad94459ddb3057f7e240f796

Revert needs uplifting to 2.0

Comment 8

[[Back July 11] Ryan VanderMeulen]

v2.0: https://github.com/mozilla-b2g/gaia/commit/de8da949e1df9cd1a50b1a47115f3307e4b849b3