1022878 - [B2G][Lockscreen] Long pressing power button on lockscreen does not bring up reboot menu

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Description:
When lockscreen is present or with lockscreen enabled and screen is off, long pressing power button does not bring up power/reboot menu until user unlocks device. Power/reboot menu functions normally when used without lock screen.


Repro Steps:
1) Update a Flame to 20140609040203
2) Short press power button to turn off screen
3) Long press power button to try to bring up power/reboot menu


Actual:
Power/reboot menu does not appear when user long presses power button on lockscreen


Expected:
Power/reboot menu appears when user long presses power button on lockscreen

Environmental Variables:
Device: Flame 2.0
Build ID: 20140609040203
Gaia: 12af93123c5db55212d51fe235d39f21209a1eaa
Gecko: 9305a8ec77fe
Version: 32.0a1 (2.0) 
Firmware Version: v10G-2

User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Notes:
Repro frequency: 3/3, 100%
See attached: Youtube video clip & logcat
Youtube Link: http://youtu.be/7mUcIEncKHE

Comment 1

[Brogan Zumwalt [Inactive]]

Issue does NOT occur on 1.4 Flame

Result: User can long press power to access reboot menu on lockscreen (but not when screen is off)

Environmental Variables:
Device: Flame 1.4
Build ID: 20140609000201
Gaia: 8b239e41bbd85aa7b6a2c5d388e775ba7de6fb2b
Gecko: e3f85877db29
Version: 30.0 (1.4) 
Firmware Version: v10G-2

Comment 2

[Roland Kunkel [:RolandK]]

Initial Regression Window: Flame - Central

Last working:
Environmental Variables:
Device: Flame 2.0
Build ID: 20140606085606
Gaia: 857129928b6e56a809cee9d5445effb8fa9f1c2c
Gecko: 7146e89a7b83
Version: 32.0a1 (2.0)
Firmware Version: v10G-2


First Broken:
Environmental Variables:
Device: Flame 2.0
Build ID: 20140606140041
Gaia: 3f3963fe6e165c0a7afc6222e1137d0862c70b30
Gecko: ba028f407ebf
Version: 32.0a1 (2.0)
Firmware Version: v10G-2

Broken Gaia with Working Gecko - Issue does NOT reproduce
Gaia: 3f3963fe6e165c0a7afc6222e1137d0862c70b30
Gecko: 7146e89a7b83


Working Gaia with Broken Gecko - Issue DOES reproduce
Gaia: 857129928b6e56a809cee9d5445effb8fa9f1c2c
Gecko: ba028f407ebf

-

B2G Inbound

- Last Working -
Environmental Variables:
Device: Flame 2.0
BuildID: 20140606053003
Gaia: d5f13789f92116ea56c6bd1aed385be38bc1177a
Gecko: 82b0ca713bd1
Version: 32.0a1
Firmware Version: V10G-2

- First Broken -
Environmental Variables:
Device: Flame 2.0
BuildID: 20140606083008
Gaia: d367579e0891b61b3b2310746e72f9db926624f7
Gecko: 2e0533956466
Version: 32.0a1
Firmware Version: V10G-2

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: d5f13789f92116ea56c6bd1aed385be38bc1177a
Gecko: 2e0533956466

First Broken Gaia Last Working Gecko: Issue DID reproduce (Indicating a Gaia issue)
Gaia:d367579e0891b61b3b2310746e72f9db926624f7
Gecko: 82b0ca713bd1

Appears to be Gaia issue

https://github.com/mozilla-b2g/gaia/compare/d5f13789f92116ea56c6bd1aed385be38bc1177a...d367579e0891b61b3b2310746e72f9db926624f7

Comment 3

[Jason Smith [:jsmith]]

Broken by bug 973827. Can you take a look?

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Jason,
You are right, this was caused by bug 973827.
I'll take this bug, looks quite easy to fix.

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Alive, I missed the lock screen in the previous patch.
Could you please take a look?
Thanks!

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8438477 [details] [review]
patch in github

r=me if this makes sleep menu is on top of everything else.

Could you try: open a webapp calls requestFullScreen and see if still could invoke sleep menu?

https://developer.mozilla.org/samples/domref/fullscreen.html

Comment 7

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Alive, Yes I can launch the sleep menu playing that video in fullscreen mode :)

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 49c56c9e1bf1c25f1b4c34a1aef97b25455f23d0

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/5e405067230af282a968be69dd00778808679ef5

Comment 10

[sarsenyev]

Verified the issue is fixed on 2.1 and 2.0

Long pressing power button on lockscreen brings up reboot menu

"Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141120001207
Gaia: f8d3bf44029e0afc0124600a4bb34dba8fc1ad21
Gecko: f70a67a7f846
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0"

"Flame 2.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141120000206
Gaia: 1ede2666f1e6c1b3fd3b282011caf0cbc59544b0
Gecko: 54f1b0ee07a6
Version: 32.0 (2.0)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0"