1022933 - [flatfish] [Browser] Bookmarks are not added to the homescreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Gabriela [:gaby2300]]

Bookmarks are not saved in the home screen using my Firefox OS 2.0 tablet

1. Open the browser
2. Browse to a site
3. Tap the white star in the lower side of the screen.
4. Tap Add to home screen
5. Go to the home screen
6. Notice the bookmark hasn't been added

Actual result: the bookmark hasn't been added to the home screen
Expected result: the bookmark should be added to the home screen

Comment 1

[Gabriela [:gaby2300]]

This issue exists using the latest 2.1 stable build as well.

Comment 2

[Abhiram Chintangal [:maitreya]]

I can confirm this bug on my device running the latest July 25th build.

Comment 3

[Sherman Chen [:chens] (inactive)]

Hi :maitreya, 

This is mostly applist issue, a good start for contributors,
if your are interested in this bug I would glad to mentor this.

Comment 4

[Abhiram Chintangal [:maitreya]]

Hi Chens,

> This is mostly applist issue, a good start for contributors,  
> if your are interested in this bug I would glad to mentor this.

Great! I can certainly use some help on this.

Comment 5

[Abhiram Chintangal [:maitreya]]

(In reply to Sherman Chen [:chens] from comment #3)
> Hi :maitreya, 
> 
> This is mostly applist issue, a good start for contributors,
> if your are interested in this bug I would glad to mentor this.

Chens, 

The bug was not present in 1.4 and after that is present in all the tablet versions. As for the applist part, can you tell me where I should start looking?

Comment 6

[Sherman Chen [:chens] (inactive)]

You can find details about applist on MDN [1].
For tablet's app list you can find it in /build/config/tablet/apps-*.list

[1]: https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Customizing_build-time_apps

Comment 7

[Sherman Chen [:chens] (inactive)]

Fixed since bug 1051672 landed.

Comment 8

[eva.chen.fx]

The issue is resolved with a TCP build from today's master.
Verified okay on my Flatfish.

OS version:2.1.0.0-prerelease
BuildID: 20140813012313
Gaia: 72bb113df0d50e179925e1ad33d6b811559331aa
Gecko:05976976d9d413d8288ac6b2f9933732552d89bf
Version: 34.0a1

Comment 9

[Gabriela [:gaby2300]]

I can verify this bug is fixed in the August 15 FFOS 2.1 build.