1022972 - Firefox "what's new" page doesn't properly detect old versions with "rv:" prefix

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Gregory Szorc [:gps]]

We are creating a Firefox hotfix add-on that attempts to upgrade old Firefox clients. See bug 928173.

We would like to show https://www.mozilla.org/projects/firefox/%VERSION%/whatsnew/?oldversion=%OLD_VERSION% on first start of the freshly-installed Firefox 30. We would love to show the amazing Australis guide version of that page.

Unfortunately, the version parsing doesn't appear to be quite up to snuff.

The hotfix will be deployed to Firefox clients as old as Firefox 10. In these clients (and up until a point unknown to me), the "old version" encoded in Firefox appears to be prefixed with "rv:".

Contrast the following URLs:

https://www.mozilla.org/en-US/firefox/30.0/whatsnew/?oldversion=10.0
(shows amazing Australis upgrade UI, but isn't what Firefox sends)

https://www.mozilla.org/en-US/firefox/30.0/whatsnew/?oldversion=rv:10.0
(shows classic UI, is what Firefox 10 actually sends)

I haven't looked at the code, but I suspect we need to strip leading "rv:" before we do the version compare.

The goal is to have the hotfix ready for deployment by EOD June 13 (this week).

Comment 1

[Gregory Szorc [:gps]]

I sent an untested pull request to GitHub. I assume somebody will tell me if I'm not doing it right.

https://github.com/mozilla/bedrock/pull/2092

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/b74d40a153da212c89606d043b93fc7db1e2dee4
Fix bug 1022972 - strip leading "rv:" from version

Old Firefox clients may prefix their version with "rv:". This patch
strips that before performing a version compare.

https://github.com/mozilla/bedrock/commit/9b5e1b332132606d670987c0ca66053fa201f669
Merge pull request #2092 from indygreg/prefixed-versions

Fix bug 1022972 - strip leading "rv:" from version

Comment 3

[Gregory Szorc [:gps]]

When will this get deployed to production? This blocks the deploy of the hotfix tracked in bug 928173. If you say any time before next week at this time, I don't think there will be a problem.

Comment 4

[Josh Mize [:jgmize]]

This is now in production.

Comment 5

[Gregory Szorc [:gps]]

I love the speed at which you move.