1022992 - FMD Doesn't Always Show as 'Enabled' in Settings Even When It Is

Status: VERIFIED FIXED

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Kate Glazko]

Attachment: Enabled Absent from Settings After Restart

This typically happens after a phone restart. After restarting phone, head to Settings. You will see Find My Device under Account Management, and there will be no disabled nor enabled text under 'Find My Device'.

When you click on FMD, if it is enabled as it was in my case, you will see that it is enabled with the blue toggle bar. However, it will flash the sign in screen for about a minute before showing the toggle bar.

When you go back to the settings, Enabled will display as it is supposed to. If you lock the phone and head to Settings, enabled will show.

Summary: After a restart, Enabled/Disabled text doesn't show in the menu. I have attached a video to demonstrate.

Comment 1

[Guilherme Gonçalves [:ggp]]

Attachment: gaia pull request

Comment 2

[Guilherme Gonçalves [:ggp]]

Comment on attachment 8438733 [details] [review]
gaia pull request

:arthurcc may be a better reviewer for this, we don't want to overwhelm :vintgetun.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8438733 [details] [review]
gaia pull request

Thank you for the patch, Guilherme! As we were refactoring settings app using AMD pattern, could you write the newly added code an AMD module in root/ and include it in root/panel.js?

The module would take a dom element as the parameter and be enabled/disabled at the right time. Please refer to root/battery_item.js for details.

Comment 4

[Guilherme Gonçalves [:ggp]]

Comment on attachment 8438733 [details] [review]
gaia pull request

Updated the PR. Thanks for the feedback, Arthur. Let me know if I missed anything!

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8438733 [details] [review]
gaia pull request

Looks much better! Please check my comments in github, thanks!

Comment 6

[Guilherme Gonçalves [:ggp]]

Updated the PR to address the comments. I haven't changed the hidden element change because I was hoping to piggyback that fix in this bug (see my response on GitHub for details, please), but the other comments have been fixed.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8438733 [details] [review]
gaia pull request

r=me, please squash the commits before merging, thanks.

Comment 8

[Guilherme Gonçalves [:ggp]]

Done, thank you!

Comment 9

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Gaia-try tests look good, merging.

Master: https://github.com/mozilla-b2g/gaia/commit/6bf7dc1a2d7f6eef651d6e4932fae8e7d70a27dd

Comment 10

[Kate Glazko]

Needs uplifting..

Comment 11

[Guilherme Gonçalves [:ggp]]

Comment on attachment 8438733 [details] [review]
gaia pull request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1022992
[User impact] if declined: Little impact, this is mostly UI polishing
[Testing completed]: Travis and manual.
[Risk to taking this patch] (and alternatives if risky): None.
[String changes made]: None.

Comment 12

[Guilherme Gonçalves [:ggp]]

No need to reopen, though.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR against v2.0

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=a4d568cd4ec2dc900e1b112e428da4aa8c1ab57b

master: 10729f6795fc6e4fad957e4e69d79a945323713c

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

I meant 2.0: 10729f6795fc6e4fad957e4e69d79a945323713c

Comment 16

[bhavana bajaj [:bajaj]]

Comment on attachment 8438733 [details] [review]
gaia pull request

Already landed in 2.0, cleaning the flag up..

Comment 17

[Josh Schmitt [Joshs]]

Issue does not repro, after restarting multiple times, "Enabled" is always shown on the Settings menu.

Environmental Variables:
Device: Flame 2.0
Build ID: 20140630000201
Gaia: c0c8ad187c0466285f2580531e09f8322996f561
Gecko: d4dc609bcc8a
Version: 32.0a2 (2.0)
Firmware Version: v122

User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 18

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame2.1.MP4

This issue has been verified successfully on Flame 2.1.

Steps:
1.Sign in Firefox account in Settings.
2.Restart device and check enabled text under 'Find My Device'.
** Enabled text under 'Find My Device' is shown.

Note: Restart device without the firefox account, The disabled text under 'Find My Device' is shown normally.
See attachment: Verify_Video_Flame2.1.MP4
Reproducing rate: 0/10

Flame v2.1 version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0