1023045 - [Settings][Ringtone][V2.0] The "<" icon of sound settings page becomes "X" icon after back from ringtone app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

+++ This bug was initially created as a clone of Bug #1016280 +++

STR
===
* Reproduction steps:
  1. Launch the settings app then tap "Sounds"
  2. Click "Manage Ringtones".
  3. Tap "<" to go to previous page
  4. Checking the "<" icon on sound settings page

* Expected result:
  The "<" icon is at the top-left corner

* Actual result:
  The "<" icon became "X" icon.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1 - pull request 20259

I have a patch to remove the 'section' when invoking settings app activity.

Jim,

Could you please review this?
Thank you.

Comment 2

[Jim Porter (:squib)]

Comment on attachment 8437422 [details] [review]
Patch V1 - pull request 20259

Based on the changes to the keyboard app in bug 1016280, this looks good to me!

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/e0c637f14265291ed81934058ec1cc019612127c

--
Jim, thanks for the review.

Comment 4

[Hema Koka [:hema]]

incorrect and mis-leading navigation control, so adding to 2.0 blocker

Comment 5

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/5a7469acff42dcbdb8d16c04c4532a264f7083c8

Comment 6

[William Hsu [:whsu]]

Good Job! Thanks everyone.
I cannot reproduce it.

* Build information:
 - Gaia      0f254c92bc44d614ae56a855f18a895a7e4703ad
 - Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/301e62e44f18
 - BuildID   20140616160201
 - Version   32.0a2

Comment 7

[Elie]

Attachment: VIDEO0050.mp4

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6
Build-ID        20141125001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2