1023087 - [Window Management] Marionette test for copy-paste

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

We need marionette test for copy-paste.

Test cases should include,
1. long press text content, check dialog displaying
2. click cut button, and check text is removed
3. click other place of content, check dialog displaying which only contains paste button
4. click paste button, check the text is added or not

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

I'll disable the test til gecko is landed.
However, I'm now waiting for device's ready, since my unagi with special build cannot run marionette test.

Comment 2

[howie [:howie]]

hi George, can we finish this on June 13? Or can you use other device?

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: long-press.py

Hi Howie,
WIP,
https://github.com/cctuan/gaia/commit/1b48c006bb39653805a61666e8eb02afc99d6a03

I'm working on that. However, I found an API issues that blocks my progress.
I cannot execute longPress event on input field no matter in js marionette(see above wip commit) nor python marionette(see attachment), so that I cannot launch the text selection dialog for following marionette tests.

Hi Morris,
I saw our python marionette api from qa for long_press is like below
""    def long_press(self, element, time_in_seconds): ""
which is different with yours.
I think the our marionette are not the same?

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Hi George,
long_press api have been updated a few days ago. Please check bug 1020874.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks Morris,

I've tried latest python-marionette from mozilla-central, but long-press still cannot work.

Now, I'm trying to reuse parts of text_selectioncarets.py from central and see if it works.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Morris, 
I would need your help ..
is it possible for you to use my commit in comment 3 and check whether those events are sent or not? Perhaps print out debug log from backend.

Comment 7

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Will do. Keep the ni flag for reminding me.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
you can also test it with the commit in comment 3,
and execute 
|make test-integration TEST_FILES=apps/system/test/marionette/copy_paste_test.js  MARIONETTE_RUNNER_HOST=marionette-device-host| to run on device.

Comment 9

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

According to our code [1], our tap action won't process by APZC. But longtap is fired by APZC so that the test is always fail. bug 932804 try to resolve this issue but not landed yet. :(

Comment 10

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

oops, forgot the link.

[1]: http://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-listener.js#693

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

I've modified the test cases as below.
1. tap input field, tap selectAll, tap copy, and tap another input field, and tap paste , and check the content.
2. tap input field, tap selectAll, tap cut, and check the content is cleaned, and tap another input field, and tap paste , and check the content.

I ignore long press test case til bug 932804 is fixed.

Hi Evan,
could you take a look of this patch?
Thanks.

Comment 12

[Evan Tseng [:evanxd]]

Hi George,

I added comments for your patch.

Thanks.

Comment 13

[Evan Tseng [:evanxd]]

Hi George,

I added comments for the patch.

Thanks.

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8444853 [details] [review]
PR to master

Hi Evan,
after rebase to latest master, the marionette stable test seems very stable. 
could you review my patch again? Thanks.

Comment 15

[Evan Tseng [:evanxd]]

Hi George,

I added some commands.
Nice, keep the tests stable.

Thanks.

Comment 16

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Evan,
issues addressed and stable tests seems pass.
Please kindly check again, thanks.

Comment 17

[Evan Tseng [:evanxd]]

Comment on attachment 8444853 [details] [review]
PR to master

Hi George,

Nice work!
Just have some nits for the patch.
Please fix them before doing merge.

Thanks.

Comment 18

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks Evan,

tbpl passed (only one expected Gi error)
https://tbpl.mozilla.org/?rev=4a3c4093af45aea5b769ca9dcc9ad084c73aceea&tree=Gaia-Try

merge to master,
https://github.com/mozilla-b2g/gaia/commit/90b96cada15403ae13dadd8090a804ad7c648774