[Flame][Keyboard] - Missing images

RESOLVED FIXED

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Carol, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Missing images for keyboards.
(Reporter)

Comment 1

4 years ago
Created attachment 8437518 [details]
images_keyboard.zip

Hi Pavel,
Please update these images for keyboard, thanks!
Flags: needinfo?(pivanov)
(Reporter)

Updated

4 years ago
Blocks: 1016987
Created attachment 8437528 [details] [review]
patch for Gaia/master

Hey Helen,
the `divider.png` was 2x100 pixels and now is 1x40 pixels ... is this correct? because if it is correct we need to fix some css part of the bug
Attachment #8437528 - Flags: ui-review?(hhuang)
Flags: needinfo?(pivanov)
(Reporter)

Comment 3

4 years ago
Created attachment 8437540 [details]
images_keyboard.zip

Hi Pavel,
I revised the images again, please switch to the new one! thanks!
Attachment #8437518 - Attachment is obsolete: true
Attachment #8437528 - Flags: review?(rlu)
Comment on attachment 8437528 [details] [review]
patch for Gaia/master

I've checked the latest assets that Carol attached. It looks okay!
Attachment #8437528 - Flags: ui-review?(hhuang) → ui-review+
Comment on attachment 8437528 [details] [review]
patch for Gaia/master

I am fine with the updated assets.

However, I am kind-of curious about the new divider asset we use here, originally we use 2-pixel wide asset with some gradient and now it is only one-pixel.

Carol,
Is this by intention?

Thanks.
Flags: needinfo?(chuang)
(Reporter)

Comment 6

4 years ago
Hey Rudy,
Yes, we want to use 1-pixel divider now, since the style had changed. Do you need to change coding because of this?
If so,let me know, I will revise the images. I don't want you to spend too much time on this minor changes.
Thanks!
Flags: needinfo?(chuang)
Comment on attachment 8437528 [details] [review]
patch for Gaia/master

No, there is code change necessary and thanks for Pavel or your effort on this.
r=me.
Attachment #8437528 - Flags: review?(rlu) → review+
Thanks all :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/4e7393f85b59c643a22c8db1e4a7868cc9d5ad04
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.