1023127 - Race condition during packaged app install on verticalhome boot may throw exceptions

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[James Lal [:lightsofapollo]]

Caught on travis https://travis-ci.org/mozilla-b2g/gaia/jobs/27178828#L3426

50% sure the problem is app.manifest is not available (or fully filled out) until the package is fully downloaded. Right now if the race is hit it will more or less break the verticalhome screen as it is displaying apps.

Needs more investigation...

Comment 1

[Kevin Grandon :kgrandon]

Running this a lot to see if it's really an issue. Maybe it's been fixed, or it was due to a lightning strike.

https://travis-ci.org/KevinGrandon/gaia/builds/27373242

Comment 2

[Kevin Grandon :kgrandon]

50 green runs, no restarts... I'm going to say we're ok here, but let's investigate if we see this again.

Comment 3

[James Lal [:lightsofapollo]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=41638009&tree=Gaia-Try

Still a problem...

Comment 4

[James Lal [:lightsofapollo]]

This also effects the search app...


E/GeckoConsole( 7675): [JavaScript Error: "TypeError: this.descriptor is undefined" {file: "app://search.gaiamobile.org/shared/elements/gaia_grid/js/items/mozapp.js" line: 46}]
E/GeckoConsole( 7675): [JavaScript Error: "TypeError: this.descriptor is undefined" {file: "app://search.gaiamobile.org/shared/elements/gaia_grid/js/items/mozapp.js" line: 46}]
E/GeckoConsole( 7675): [JavaScript Error: "TypeError: manifest is undefined" {file: "app://search.gaiamobile.org/shared/elements/gaia_grid/js/items/mozapp.js" line: 112}]
E/GeckoConsole( 7675): [JavaScript Error: "TypeError: manifest is undefined" {file: "app://search.gaiamobile.org/shared/elements/gaia_grid/js/items/mozapp.js" line: 112}]
E/GeckoConsole( 7675): [JavaScript Error: "TypeError: manifest is undefined" {file: "app://search.gaiamobile.org/shared/elements/gaia_grid/js/items/mozapp.js" line: 112}]
E/GeckoConsole( 7675): [JavaScript Error: "TypeError: manifest is undefined" {file: "app://search.gaiamobile.org/shared/elements/gaia_grid/js/items/mozapp.js" line: 112}]
E/GeckoConsole( 7675): [JavaScript Error: "TypeError: manifest is undefined" {file: "app://search.gaiamobile.org/shared/elements/gaia_grid/js/items/mozapp.js" line: 112}]
E/GeckoConsole( 7675): [JavaScript Error: "TypeError: manifest is undefined" {file: "app://search.gaiamobile.org/shared/elements/gaia_grid/js/items/mozapp.js" line: 112}]


Effectively breaks search (I see no results) worth some debugging time.

Comment 5

[Kevin Grandon :kgrandon]

This was on my branch I'm assuming? I had rebase errors there =/

I think we can close this, but just wanted to check with you...

Comment 6

[Kevin Grandon :kgrandon]

I am pretty sure this was my bad on that pull request - I had a rebase error and was passing in an invalid object, causing it to fail 100% of the time. Let me know if you still think it's a problem.