[Flame][Browser]Update missing images

RESOLVED FIXED

Status

Firefox OS
Gaia::Browser
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: HHuang, Unassigned)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(feature-b2g:2.0)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Need to update some missing images, and replace the outdated assets.
(Reporter)

Updated

3 years ago
Blocks: 1016987
(Reporter)

Comment 1

3 years ago
Created attachment 8437546 [details]
Browser missing images.zip

Hi Pavel, Please help to update them, thanks!
Flags: needinfo?(pivanov)
Created attachment 8437564 [details] [review]
patch for Gaia/master

Hey Hellen,
I think we don't use `menu-pressed` images anymore, can you confirm? Because I don't see them in the code.

BTW: I also compressed all images in Browser App
Attachment #8437564 - Flags: ui-review?(hhuang)
Flags: needinfo?(pivanov)
(Reporter)

Comment 3

3 years ago
Hi Pavel,

Thanks for your reminder, I also can't find it in Browser App... Could you help to remove them?
- menu.png
- menu@1.5x.png
- menu@2x.png
- menu@2.25x.png
- menu-pressed.png
- menu-pressed@1.5x.png
- menu-pressed@2x.png
- menu-pressed@2.25x.png


And I also found a updated file was wrong, please remove it.
apps/browser/style/images/gradient_background@2.25x.psd
Flags: needinfo?(pivanov)
Done :) ui-f?
Flags: needinfo?(pivanov) → needinfo?(hhuang)
(Reporter)

Comment 5

3 years ago
Comment on attachment 8437564 [details] [review]
patch for Gaia/master

Thanks Pavel!
Attachment #8437564 - Flags: ui-review?(hhuang) → ui-review+
Flags: needinfo?(hhuang)
Attachment #8437564 - Flags: review?(bfrancis)
Attachment #8437564 - Flags: review?(bfrancis) → review+
I've restarted some erroring Travis jobs, please land once Travis is green.

If this is needed in 2.0 then approval will need to be requested.

Thanks!
Thanks Ben :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/641f7d1ac37d4321f69ccb0db4ac3aedcaddadfd
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Hey Steph,
do we need this for 2.0?
Flags: needinfo?(swilkes)

Comment 9

3 years ago
All missing and fuzzy graphics should be in for 2.0. Otherwise they count as regressions.
feature-b2g: --- → 2.0
Flags: needinfo?(swilkes)
You need to log in before you can comment on or make changes to this bug.