1023138 - [Flame][Browser]Update missing images

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Helen Huang [:HHuang]]

Need to update some missing images, and replace the outdated assets.

Comment 1

[Helen Huang [:HHuang]]

Attachment: Browser missing images.zip

Hi Pavel, Please help to update them, thanks!

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Hey Hellen,
I think we don't use `menu-pressed` images anymore, can you confirm? Because I don't see them in the code.

BTW: I also compressed all images in Browser App

Comment 3

[Helen Huang [:HHuang]]

Hi Pavel,

Thanks for your reminder, I also can't find it in Browser App... Could you help to remove them?
- menu.png
- [e-mail]
- [e-mail]
- [e-mail]
- menu-pressed.png
- [e-mail]
- [e-mail]
- [e-mail]


And I also found a updated file was wrong, please remove it.
apps/browser/style/images/[e-mail]

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Done :) ui-f?

Comment 5

[Helen Huang [:HHuang]]

Comment on attachment 8437564 [details] [review]
patch for Gaia/master

Thanks Pavel!

Comment 6

[Ben Francis [:benfrancis]]

I've restarted some erroring Travis jobs, please land once Travis is green.

If this is needed in 2.0 then approval will need to be requested.

Thanks!

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Ben :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/641f7d1ac37d4321f69ccb0db4ac3aedcaddadfd

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Steph,
do we need this for 2.0?

Comment 9

[Stephany Wilkes]

All missing and fuzzy graphics should be in for 2.0. Otherwise they count as regressions.