Closed Bug 1023140 Opened 10 years ago Closed 10 years ago

[Email] Missing images

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::E-Mail
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: fang, Unassigned)

References

Details

Attachments

(4 files)

Email_missing images_@2.25.zip
77.17 KB, application/zip
Details
patch for Gaia/master
46 bytes, text/x-github-pull-request
jrburke
: review+
jrburke
: ui-review+
Details | Review
Email_missing_images_@2.25x_0611.zip
119.20 KB, application/zip
Details
Missing_images_0612.zip
319.22 KB, application/zip
Details 
Noticed that Email app is missing some icons in size @2.25x. 

I’ve attached the icons in @2.25x, Here are the list of icons that needs to update:

./apps/email/style/images/icons/actionicon_attachments@2.25x.png
./apps/email/style/images/icons/actionicon_email_addrecipient@2.25x.png
./apps/email/style/images/icons/actionicon_email_addrecipient_press@2.25x.png
./apps/email/style/images/icons/actionicon_email_removeattachment@2.25x.png
./apps/email/style/images/icons/arrow_down@2.25x.png
./apps/email/style/images/icons/arrow_down_press@2.25x.png
./apps/email/style/images/icons/arrow_up@2.25x.png
./apps/email/style/images/icons/arrow_up_press@2.25x.png
./apps/email/style/images/icons/delete@2.25x.png
./apps/email/style/images/icons/download@2.25x.png
./apps/email/style/images/icons/edit-mode@2.25x.png
./apps/email/style/images/icons/folder_icon@2.25x.png
./apps/email/style/images/icons/folder_icon_press@2.25x.png
./apps/email/style/images/icons/forward@2.25x.png
./apps/email/style/images/icons/icon_default@2.25x.png
./apps/email/style/images/icons/icon_image@2.25x.png
./apps/email/style/images/icons/icon_music@2.25x.png
./apps/email/style/images/icons/icon_outbox_pending@2.25x.png
./apps/email/style/images/icons/icon_outbox_sending@2.25x.png
./apps/email/style/images/icons/icon_video@2.25x.png
./apps/email/style/images/icons/mark@2.25x.png
./apps/email/style/images/icons/message-list-attachment@2.25x.png
./apps/email/style/images/icons/message-list-star@2.25x.png
./apps/email/style/images/icons/move@2.25x.png
./apps/email/style/images/icons/refresh@2.25x.png
./apps/email/style/images/icons/remove_message@2.25x.png
./apps/email/style/images/icons/reply-all@2.25x.png
./apps/email/style/images/icons/reply@2.25x.png
./apps/email/style/images/icons/search@2.25x.png
./apps/email/style/images/icons/settings_icon@2.25x.png
./apps/email/style/images/icons/settings_icon_press@2.25x.png
./apps/email/style/images/icons/star@2.25x.png
./apps/email/style/images/icons/star_on@2.25x.png
./apps/email/style/images/icons/undo@2.25x.png 

***

Also, I think there are few icons we don't really use it anymore. Wonder if they are outdated? I may need some help with it, is there a way to confirm if they are still in use? 

Here is the list of icons that needs to confirm: 
./apps/email/style/images/default@2x.png
./apps/email/style/images/default@2.25x.png
./apps/email/style/images/gradient@2x.png
./apps/email/style/images/gradient@2.25x.png./apps/email/style/images/icons/settings@2.25x.png./apps/email/style/images/mail_watermark@1.5x.png
./apps/email/style/images/mail_watermark@2x.png
./apps/email/style/images/mail_watermark@2.25x.png
./apps/email/style/images/pattern@1.5x.png
./apps/email/style/images/pattern@2x.png
./apps/email/style/images/pattern@2.25x.png
./apps/email/style/images/ui/dark_header@1.5x.png
./apps/email/style/images/ui/dark_header@2x.png
./apps/email/style/images/ui/dark_header@2.25x.png
./apps/email/style/images/ui/separator-large@2.25x.png
./apps/email/style/images/ui/separator@2.25x.png

Thanks!
Blocks: 1016987
Hey Fang,

We need these:
./apps/email/style/images/default@2x.png
./apps/email/style/images/default@2.25x.png
./apps/email/style/images/gradient@2x.png
./apps/email/style/images/gradient@2.25x.png
./apps/email/style/images/pattern@1.5x.png
./apps/email/style/images/pattern@2x.png
./apps/email/style/images/pattern@2.25x.png
./apps/email/style/images/ui/dark_header@1.5x.png
./apps/email/style/images/ui/dark_header@2x.png
./apps/email/style/images/ui/dark_header@2.25x.png
./apps/email/style/images/ui/separator@2.25x.png
./apps/email/style/images/ui/separator-large@2.25x.png

We don't use these:
apps/email/style/images/icons/settings@2.25x.png
apps/email/style/images/mail_watermark@1.5x.png
apps/email/style/images/mail_watermark@2x.png
apps/email/style/images/mail_watermark@2.25x.png


Thanks :)
Hi Pavel,

Thanks for the help! 
I've attached the rest of missing images:
./apps/email/style/images/default@2x.png
./apps/email/style/images/default@2.25x.png
./apps/email/style/images/gradient@2x.png
./apps/email/style/images/gradient@2.25x.png
./apps/email/style/images/pattern@1.5x.png
./apps/email/style/images/pattern@2x.png
./apps/email/style/images/pattern@2.25x.png
./apps/email/style/images/ui/dark_header@1.5x.png
./apps/email/style/images/ui/dark_header@2x.png
./apps/email/style/images/ui/dark_header@2.25x.png
./apps/email/style/images/ui/separator@2.25x.png
./apps/email/style/images/ui/separator-large@2.25x.png

Can you help to remove the images that we don't use? 
apps/email/style/images/icons/settings@2.25x.png
apps/email/style/images/mail_watermark@1.5x.png
apps/email/style/images/mail_watermark@2x.png
apps/email/style/images/mail_watermark@2.25x.png

Thanks!! : )
I believe these images are related to the fork of the value selector that email has. Bug 890647 is about trying to see if we can unfork our copy and use the shared version. I hope to look at it this week. :ivanovpavel, if you have any feedback on that feel free to let me know. I am not sure yet if it will work out, so this ticket's work is still good to have ready.
Hey James,
on prima vista I think that you will not have a problems to switch from the custom value selector to the shared one ... maybe with few layout tweaks.
Hey Fang,
I update the PR so you can check it and ui-f? 

Thanks :)
Flags: needinfo?(fshih)
Hi Pavel,

Thanks for the update. 
After I checked this on my device. I noticed there are few icons still look blurry. I've screenshot it with an attached file. 

1) Seen when tapping "reply" while reading a message:

* reply@2.25x.png
* reply_all@2.25x.png

2) The next and back arrow button in the upper right while reading a message:

* email_back@2.25x.png
* email_next@2.25x
(I think I missing these two icons in @2.25x, so I also added the update icon in this attachment)  

Thanks!
Flags: needinfo?(fshih) → needinfo?(pivanov)
Hey Fang,

I open a bug for these icons (Bug 1024295)
No longer depends on: 1024295
Flags: needinfo?(pivanov)
Attachment #8437598 - Flags: review?(jrburke)
Comment on attachment 8437598 [details] [review]
patch for Gaia/master

As long as these images have been passed through gaia's tools/png_recompress.sh then r+ from me.
Attachment #8437598 - Flags: ui-review?(fshih)
Attachment #8437598 - Flags: ui-review+
Attachment #8437598 - Flags: review?(jrburke)
Attachment #8437598 - Flags: review+
Yep I ran the png_recompress tool again :) Thanks James

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/673f796e5fdc0146c8c20bea763fdaadeb1ab6c1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: