1023220 - [Session Restore] Revert to previous semantics of FX_SESSION_RESTORE_FILE_SIZE_BYTES

Status: NEW

(Firefox :: Session Restore, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

Bug 961665 changed the semantics of FX_SESSION_RESTORE_FILE_SIZE_BYTES and made it useless, because the value exceeds the upper bounds of that histogram.

We should make sure that FX_SESSION_RESTORE_FILE_SIZE_BYTES is the size of sessionstore.js when we read it, not when we write it.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

I just reverted the file reading code to NetUtil and compared the measurements and I don't see any different numbers. David, can you remember what we thought was causing this?

Comment 2

[David Teller [:Yoric] - still alive but not very active]

We now measure code when we write. Since most of our writes deal with the crash recovery versions of sessionstore.js, which contain more data, I'm pretty sure that we increased the values.

Also, barring any mistake, we had a big bump in FX_SESSION_RESTORE_FILE_SIZE_BYTES with bug 961665.