1023238 - "Remember my choice" is not the default option pre-selected in GUM permission

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Maria Angeles Oteo (:oteo)]

In bug 938467 was agreed that "Remember my choice" option should preselected by default.
Testing a Loop call with a two-camera and a one-camera device, the option to remember the decision is not selected.

See screenshots from a flame and a buri device

Comment 2

[Maria Angeles Oteo (:oteo)]

Attachment: Flame.png

Comment 3

[Maria Angeles Oteo (:oteo)]

Attachment: Buri_gUM.png

Comment 4

[Jason Smith [:jsmith]]

Is the test app being used to test this here - https://github.com/mozilla-b2g/firefoxos-loop-client/blob/master/manifest.webapp?

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Jason Smith [:jsmith] from comment #4)
> Is the test app being used to test this here -
> https://github.com/mozilla-b2g/firefoxos-loop-client/blob/master/manifest.
> webapp?

You could give a try with the app at [1]. Please, as it is still under development let me know if you hit any issue while testing with the app.

[1] https://github.com/jaoo/firefoxos-loop-client/commits/demo-bug-1023238

Comment 6

[Maria Angeles Oteo (:oteo)]

Jason, to reproduce the bug you need to install the Loop application provided by Jose Antonio with the Application manager (as a privileged application)

Comment 7

[[e-mail]]

looks like we did not take the right condition criteria for app
https://github.com/gasolin/gaia/blob/master/apps/system/js/permission_manager.js#L274

Comment 8

[[e-mail]]

pointer to mozilla-b2g/gaia https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/permission_manager.js#L303

Comment 9

[[e-mail]]

Attachment: pull request redirect to github

test included

Comment 10

[Jason Smith [:jsmith]]

Wrong behavior in a privileged app - we need to block on this.

Comment 11

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/14721fa57d9994ed560db32a15b4fa3191d84a9d

thanks!

Comment 12

[Ivan Tsay (:ITsay)]

Nominate it to 2.0+ since this is also the 2.0 blocker for webRTC client.

Comment 13

[Ivan Tsay (:ITsay)]

Clean ni? to Fred because I meant to nominate the bug to 2.0+ only.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/eae3e949362158dd1d08fe6565552240038d7cfd

Comment 15

[sarsenyev]

Verified the issue is fixed on 2.1 and 2.0 Flame

"Remember my choice" is the default option pre-selected in GUM permission

"Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141120001207
Gaia: f8d3bf44029e0afc0124600a4bb34dba8fc1ad21
Gecko: f70a67a7f846
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0"

"Flame 2.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141120000206
Gaia: 1ede2666f1e6c1b3fd3b282011caf0cbc59544b0
Gecko: 54f1b0ee07a6
Version: 32.0 (2.0)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0"