1023338 - [WAP Push][CP] If a second configuration message is received with the same apn name than a previous stored one, it is not selected by default (follow-up bug 1015875)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Wappush, defect)

Description

[isabelrios]

Attachment: 2014-06-10-11-26-39.png

Buri 2.0 build (06/10):

Gecko-c146f3f
Gaia-3b2ae74

STR
-Receive a OMA CP message, process it.
-Go to Settings -> Cellular & Data -> Data settings and check that the APN received has been selected by default
-Receive the another OMA CP message with the same configuration, same APN name
-Go to Settings -> Cellular & Data -> Data settings and check that the APN received has been selected by default

EXPECTED
The lastest APN received is the one selected by default

ACTUAL
If an APN just received has the same name than an APN already stored, it will never be selected by default when is received

Please see screenshot attached. The second APN listed with Telefonica 1 name was received the latest, but it is not selected by default as there was already one Telefonica 1 APN stored.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Oh, really bad. This was fixed in bug 998914. In bug 1015875 we set the APN received through the OMA CP message in the 'ril.data.apnSettings' setting without taking care of other APNs with the same name could be already stored in the 'ril.data.cp.apns'. We will take care of that in this bug as a follow-up bug of bug 1015875. We just need to add the 'hashCode' property to the APNs being received through the OMA CP messages. That way the last APN received will be the one selected in the APN panels in the setting app.

Comment 2

[Jason Smith [:jsmith]]

blocking as the bug this is related was a cert blocker. Adding qawanted to check 1.4.

Comment 3

[Albert [:albert]]

Attachment: Patch

Added an id to external APNs coming from wappush, so instead of having same name/carrier each one can be identified.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8446669 [details]
Patch

Looks promising, specially because it solves the issue with a few changes. Sadly the issue raised in this bug cannot be caught in the WAP PUSH app tests as it store the APN and that's it. We could add a simple test in the settings app in which we test the APN pre-selection works as expected even with the id APN property added in this patch for every APN installed through the WAP PUSH app.

Comment 5

[Albert [:albert]]

Comment on attachment 8446669 [details]
Patch

Added requested tests.

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8446669 [details]
Patch

(In reply to Albert [:albert] from comment #5)
> Comment on attachment 8446669 [details]
> Patch
> 
> Added requested tests.

Great, I've tested this on a device receiving OMA CP message from a real server and seems to work fine a nothing is broken taking this patch. Tests pass so we are ready to go. Before landing this I'd like to request Isabel a quick test from her side.

Albert, you could land this when Isabel give us the ok.

Thanks for taking care of it

Comment 7

[isabelrios]

Just checked the patch on master and it seems to be working fine.
Good work! Thank you!

Comment 8

[Albert [:albert]]

Master: https://github.com/mozilla-b2g/gaia/commit/5406c1c0118819628d1deb9b58f9e9ae364b4825

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/90605754e9bdbe20f3999522f9e1aec600c422a4

Comment 10

[Loli (:lolimartinezcr)]

Bug tested by Juanjo, user can see correct behavior in:

https://www.dropbox.com/s/kksner4u0zkvo71/MOV_0095.mp4

Flame
2.1
Gecko-329b2e4
Gaia-da11dba

2.0
Gecko-329b2e4
Gaia-da11dba