Closed Bug 1023345 Opened 10 years ago Closed 10 years ago

[1.4/master] Update the semi-auto telephony test code to use the new telephony.dial promise

Categories

(Firefox OS Graveyard :: Certification Suite, defect)

Product:
Firefox OS Graveyard
Component:
Certification Suite
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rwood, Assigned: rwood)

References

Details

For 1.4 and forward, the MozTelephony.dial() API was changed to return a promise instead of returning a TelephonyCall object (see bug 969218). Therefore the existing semi-auto WebAPI telephony test that makes an outgoing call, which currently works with 1.3, will not work for 1.4 and forward.

Once we branch the fxos-certsuite, update the test_telephony_outgoing test for the above change for 1.4+. Currently there is only the one outgoing call test, however in the future more tests will be developed that make outgoing calls, which will be different in 1.3 vs 1.4+.
This change can be made in the common code module that is used by all the telephony tests:

https://github.com/mozilla-b2g/fxos-certsuite/blob/master/webapi_tests/telephony/telephony_test.py#L149
Also a small change is required in the existing SMS tests (remove an existing bug work-around).
Summary: Semiauto telephony WebAPI outgoing call test change for 1.4+ → Update existing semi-auto webapi tests for 1.4+
Update: A fix to testcase.py is required since the name of the gaia method to unlock the screen has changed. With that fix, all of the existing semi-auto webapi tests pass on Flame with 1.4 except for the Telephony tests which need to be updated to use the new outgoing call promise.
The telephony tests cannot be updated for 1.4 right now as for some reason in 1.4 the dialer agent cannot be disabled. For the time being, for this sprint, creating a patch that will fix the lock screen and remove the telephony tests from master / 1.4, so that all of the other existing semiauto tests will run on 1.4.
Merged: https://github.com/mozilla-b2g/fxos-certsuite/commit/e08b42518be8016e079d0e34d4c418d0dbf76a06

Leaving bug open for the future 1.4 telephony test updates.
Summary: Update existing semi-auto webapi tests for 1.4+ → [1.4/master] Update the semi-auto telephony test code to use the new telephony.dial promise
PR (for 1.4 only), which also enables the two existing telephony tests on 1.4 once again:

https://github.com/mozilla-b2g/fxos-certsuite/pull/144
Merged: https://github.com/mozilla-b2g/fxos-certsuite/commit/c0e435dc788bcc54f2c0f831d91fecda8583d5e2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.