Closed Bug 1023392 Opened 6 years ago Closed 6 years ago

Intermittent localization_test.js | Vertical - Localization Localization updates icon names

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

defect
Not set

Tracking

(b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S4 (20june)
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: jgriffin, Assigned: kgrandon)

References

Details

(Keywords: intermittent-failure, Whiteboard: [p=1],[systemsfe])

Attachments

(1 file)

07:38:02     INFO -  TEST-START | Vertical - Localization Localization updates icon names
07:38:21     INFO -  TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/verticalhome/test/marionette/localization_test.js | Vertical - Localization Localization updates icon names
07:38:21     INFO -  TEST-END | Vertical - Localization Localization updates icon names

https://tbpl.mozilla.org/php/getParsedLog.php?id=41447300&tree=B2g-Inbound&full=1
QA Whiteboard: [VH-FC-blocking-]
Kevin - This is the key blocker right now to why gaia integration tests are hidden on TBPL. Can you find someone to look into this or redirect to someone who can fix this?
Flags: needinfo?(kgrandon)
Oh sure, we actually had a patch for this that I believe got backed out of another bug. The fix for this isn't too bad.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Flags: needinfo?(kgrandon)
Attached file Github pull request
James - I think you fixed this, but I'm not sure where. Should we land this?
Attachment #8438017 - Flags: review?(jlal)
Whiteboard: [p=1],[systemsfe]
Target Milestone: --- → 2.0 S4 (20june)
Comment on attachment 8438017 [details] [review]
Github pull request

Got a r+ from James over IRC.
Attachment #8438017 - Flags: review?(jlal) → review+
Looking very green on travis, and previously not as healthy: https://travis-ci.org/KevinGrandon/gaia/builds/27264072 

I think we can land this.
Landed: https://github.com/mozilla-b2g/gaia/commit/fca906183e6fae9463119a5fde3e397fcb9a6f5c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8438017 [details] [review]
Github pull request

This is needed for the vertical homescreen. We've put forward a best effort to believe that this is safe for uplift and the tree will remain green.
Attachment #8438017 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8438017 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Hi Jonathan,

Could you please provide the detailed reproduce steps or video for me to verify this bug?
Thank you very much!
Flags: needinfo?(jgriffin)
This looks like a test only issue. It's pretty clear from the bug title/description. No verification should be necessary.
Flags: needinfo?(jgriffin)
You need to log in before you can comment on or make changes to this bug.