Closed Bug 1023413 Opened 10 years ago Closed 10 years ago

Introduce bool nsICacheStorage.exists(nsIURI, ACString)

Categories

(Core :: Networking: Cache, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

Attachments

(1 file, 1 obsolete file)

This should give a sync result.  Thinking of a tri-state logic here.  When index is not up-to-date, we could just throw, NS_ERROR_IN_PROGRESS?
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attached patch v1 (obsolete) — Splinter Review
Attachment #8437902 - Flags: review?(michal.novotny)
Summary: Introduce bool nsICacheStorage.entryExists(nsIURI, ACString) → Introduce bool nsICacheStorage.exists(nsIURI, ACString)
Attachment #8437902 - Flags: review?(michal.novotny) → review+
sorry had to back this out in https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8c81fc70045c since it seems that one of this 3 csets cause failing xpcshell tests on android 2.2 Armv6 like this https://tbpl.mozilla.org/php/getParsedLog.php?id=42255066&tree=Mozilla-Inbound
(In reply to Carsten Book [:Tomcat] from comment #2)
> sorry had to back this out in
> https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8c81fc70045c since it
> seems that one of this 3 csets cause failing xpcshell tests on android 2.2
> Armv6 like this
> https://tbpl.mozilla.org/php/getParsedLog.php?id=42255066&tree=Mozilla-
> Inbound

Thanks, seems like it's caused by this bug since it's the new test introduced here that is failing.  What androidity is that again..?  I will check and probably just disable on android, I assume there is some weird setting on armv6 as usual.
Forgot that mem cache is disabled on And.

https://tbpl.mozilla.org/?tree=Try&rev=df64ac05c87e
Attached patch v1.1Splinter Review
as v1 but disabled the new test on Android.
Attachment #8437902 - Attachment is obsolete: true
Attachment #8444481 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/325e187a682a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Shouldn't the test_cache2-24-exists.js be guarded with newCacheBackEndUsed() like http://dxr.mozilla.org/comm-central/source/mozilla/netwerk/test/unit/test_cache2-23-read-over-chunk.js#7 ?
(In reply to Joshua Cranmer [:jcranmer] from comment #8)
> Shouldn't the test_cache2-24-exists.js be guarded with newCacheBackEndUsed()
> like
> http://dxr.mozilla.org/comm-central/source/mozilla/netwerk/test/unit/
> test_cache2-23-read-over-chunk.js#7 ?

Bug 1032594.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: