1023469 - Replace generic observer in browser.js when the observer is first used

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Working on bug 1023461 to get us JS frames during hangs, I noticed hangs inside the anonymous function at [1], but that doesn't tell us which observer it is. One way to fix it is to replace the anonymous function with the actual observer when the observer is first used.

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js?rev=37a48cebd120#126

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Replace generic observer with specific ones in browser.js;

Replace the generic observer when it's first called, so that subsequent calls will be made on the actual observers, and hang stacks will show the correct script.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Try, https://tbpl.mozilla.org/?tree=Try&rev=f698cdf12554

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/43ff2a7f349c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43ff2a7f349c