Closed
Bug 1023542
Opened 10 years ago
Closed 10 years ago
Review and push updated JSON for resources section
Categories
(Webmaker Graveyard :: Teaching Kits / Curriculum, defect)
Webmaker Graveyard
Teaching Kits / Curriculum
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: matt, Assigned: matt)
References
Details
(Whiteboard: [resources] [qa] [june27] [prod])
Attachments
(4 files, 2 obsolete files)
No description provided.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → matt
Whiteboard: [resources] [qa] [june13]
Assignee | ||
Comment 1•10 years ago
|
||
* Next step: Kate and Matt need to huddle on good process for comiting these copy fixes
Assignee | ||
Comment 2•10 years ago
|
||
@ Brett: can you take: * Sharing * Collaborating * Community Participation * Privacy * Open Practices I'll take the rest?
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(brett)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 4•10 years ago
|
||
Attachment #8438698 -
Flags: review?(ali)
Comment 5•10 years ago
|
||
Attachment #8438700 -
Flags: review?(ali)
Updated•10 years ago
|
Attachment #8438698 -
Flags: review?(ali) → review+
Updated•10 years ago
|
Attachment #8438700 -
Flags: review?(ali) → review+
Comment 6•10 years ago
|
||
Updated•10 years ago
|
Attachment #8438703 -
Flags: review+
Assignee | ||
Comment 7•10 years ago
|
||
@ Brett: which pages have you completed so far?
Flags: needinfo?(brett)
Comment 8•10 years ago
|
||
Just committed and had reviews on: * Sharing * Collaborating * Community Participation * Open Practices
Flags: needinfo?(brett)
Assignee | ||
Comment 9•10 years ago
|
||
* I'm still working on this. Will commit what I have EOD today.
Assignee | ||
Updated•10 years ago
|
Whiteboard: [resources] [qa] [june13] → [resources] [qa] [june27]
Assignee | ||
Comment 10•10 years ago
|
||
Assignee | ||
Comment 11•10 years ago
|
||
* I have completed my copy fixes and QA for: Navigation Web Mechanics Search Credibility Security Creating for the Web Composing for the web Remixing Design and Accessibility Coding/scripting Infrastructure * Updates to JSON are in the attached txt file.
Assignee | ||
Comment 12•10 years ago
|
||
* Ali: would you be able to: * Review and edit my attachment? I'm sure I made several JSON errors * Then commit it to staging?
Assignee: matt → ali
Flags: needinfo?(ali)
Assignee | ||
Comment 13•10 years ago
|
||
* Ali can't get to this today * Kate: is there anyone else we can assign this review to?
Flags: needinfo?(ali) → needinfo?(kate)
Assignee | ||
Updated•10 years ago
|
Summary: Complete all copy QA on resources section → Review and push updated JSON for resources section
Whiteboard: [resources] [qa] [june27] → [resources] [qa] [june27] [prod]
Assignee | ||
Updated•10 years ago
|
Assignee: ali → aki
Assignee | ||
Comment 15•10 years ago
|
||
* Aki: can you take this one today? Ping me in IRC and we can discuss.
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(aki)
Updated•10 years ago
|
Attachment #8440703 -
Flags: review+
Flags: needinfo?(aki)
Comment 16•10 years ago
|
||
Attachment #8440703 -
Attachment is obsolete: true
Comment 17•10 years ago
|
||
Comment on attachment 8441060 [details] [review] https://github.com/mozilla/webmaker.org/pull/809 If all the CTAs are identical, why have them in the JSON and not in the template?
Flags: needinfo?(matt)
Assignee | ||
Comment 18•10 years ago
|
||
* @ Aki: there's small differences in the wording for each. Which we may want to customize further down the road.
Flags: needinfo?(matt)
Assignee | ||
Comment 19•10 years ago
|
||
@ Aki: is this now on staging? Mark resolved?
Flags: needinfo?(aki)
Comment 20•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/8dbfff8cb3949a502a04bff51f21e4ecc7e0336f Bug 1023542 - Review and push updated JSON for resources section https://github.com/mozilla/webmaker.org/commit/0f0f374b622b048679847136fde8931a90fbccb4 Merge pull request #809 from gesa/1023542/open-matt-content-update Bug 1023542 - Review and push updated JSON for resources section
Comment 22•10 years ago
|
||
Alright OpenMatt, these changes are on staging, need another round of reviews. I caught a bunch of typos and a couple of missed </a>'s, definitely could use a second set of eyes.
Assignee: aki → matt
Assignee | ||
Comment 23•10 years ago
|
||
* Thank you! You are my JSON Angel :) * Looks like the CTAs on these pages are missing? https://webmaker.mofostaging.net/en-US/resources/literacy/weblit-Navigation https://webmaker.mofostaging.net/en-US/resources/literacy/weblit-Search etc. even though it was in the JSON? 1) Can you add those? 2) Can we push this from staging to production at earliest opportunity? This is already better than what's currently on production, so might as well push. (As long as that won't break anything else.)
Flags: needinfo?(aki)
Comment 24•10 years ago
|
||
Attachment #8441060 -
Attachment is obsolete: true
Attachment #8442225 -
Flags: review?(kate)
Comment 25•10 years ago
|
||
Just to confirm: - weblit-Sharing has no CTAs - weblit-Collaborating has no CTAs - weblit-Community has no CTAs - weblit-Privacy CTAs are blank - weblit-OpenPractices has no CTAs
Flags: needinfo?(aki) → needinfo?(matt)
Comment 26•10 years ago
|
||
Comment on attachment 8442225 [details] [review] https://github.com/mozilla/webmaker.org/pull/815 Looks ok to me, but yeah, we confirm those empty ctas
Attachment #8442225 -
Flags: review?(kate) → review+
Assignee | ||
Comment 27•10 years ago
|
||
Aki: yes, those ones are empty, cuz Brett did QA on those pages and didn't add them * But that's ok. Let's solve that in another ticket. And push this one now.
Flags: needinfo?(matt)
Comment 28•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/d16daff39e963c5c86cd42483e2524444209d94c Bug 1023542 - Review and push updated JSON for resources section https://github.com/mozilla/webmaker.org/commit/80ced273532e4f739489774ce0c0ecc631bc5bdd Merge pull request #815 from gesa/1023542/more-json-copy Bug 1023542 - Review and push updated JSON for resources section
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•