1023542 - Review and push updated JSON for resources section

Status: RESOLVED FIXED

(Webmaker Graveyard :: Teaching Kits / Curriculum, defect)

Comment 1

[Matt Thompson (@OpenMatt :OpenMatt)]

* Next step: Kate and Matt need to huddle on good process for comiting these copy fixes

Comment 2

[Matt Thompson (@OpenMatt :OpenMatt)]

@ Brett: can you take:

* Sharing
* Collaborating
* Community Participation
* Privacy
* Open Practices 

I'll take the rest?

Comment 3

[Brett Gaylor [:brett]]

10-4

Comment 4

[Brett Gaylor [:brett]]

Attachment: 2 commits to webmaker.org for resources section

Comment 5

[Brett Gaylor [:brett]]

Attachment: Final commit

Comment 6

[Brett Gaylor [:brett]]

Attachment: Quick fix for translation strings

Comment 7

[Matt Thompson (@OpenMatt :OpenMatt)]

@ Brett: which pages have you completed so far?

Comment 8

[Brett Gaylor [:brett]]

Just committed and had reviews on:

* Sharing
* Collaborating
* Community Participation
* Open Practices

Comment 9

[Matt Thompson (@OpenMatt :OpenMatt)]

* I'm still working on this. Will commit what I have EOD today.

Comment 10

[Matt Thompson (@OpenMatt :OpenMatt)]

Attachment: Resources fixes -- navigation to infrastructure

Comment 11

[Matt Thompson (@OpenMatt :OpenMatt)]

* I have completed my copy fixes and QA for:
Navigation
Web Mechanics
Search
Credibility
Security
Creating for the Web
Composing for the web
Remixing
Design and Accessibility
Coding/scripting
Infrastructure


* Updates to JSON are in the attached txt file.

Comment 12

[Matt Thompson (@OpenMatt :OpenMatt)]

* Ali: would you be able to:

* Review and edit my attachment? I'm sure I made several JSON errors
* Then commit it to staging?

Comment 13

[Matt Thompson (@OpenMatt :OpenMatt)]

* Ali can't get to this today
* Kate: is there anyone else we can assign this review to?

Comment 14

[inactivate account for kate]

Try Gavin, Aki, or me

Comment 15

[Matt Thompson (@OpenMatt :OpenMatt)]

* Aki: can you take this one today? Ping me in IRC and we can discuss.

Comment 16

[Aki Rose Braun [:akirose]]

Attachment: https://github.com/mozilla/webmaker.org/pull/809

Comment 17

[Aki Rose Braun [:akirose]]

Comment on attachment 8441060 [details] [review]
https://github.com/mozilla/webmaker.org/pull/809

If all the CTAs are identical, why have them in the JSON and not in the template?

Comment 18

[Matt Thompson (@OpenMatt :OpenMatt)]

* @ Aki: there's small differences in the wording for each. Which we may want to customize further down the road.

Comment 19

[Matt Thompson (@OpenMatt :OpenMatt)]

@ Aki: is this now on staging? Mark resolved?

Comment 20

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/8dbfff8cb3949a502a04bff51f21e4ecc7e0336f
Bug 1023542 - Review and push updated JSON for resources section

https://github.com/mozilla/webmaker.org/commit/0f0f374b622b048679847136fde8931a90fbccb4
Merge pull request #809 from gesa/1023542/open-matt-content-update

Bug 1023542 - Review and push updated JSON for resources section

Comment 21

[Aki Rose Braun [:akirose]]

Working on getting this to staging now.

Comment 22

[Aki Rose Braun [:akirose]]

Alright OpenMatt, these changes are on staging, need another round of reviews. I caught a bunch of typos and a couple of missed </a>'s, definitely could use a second set of eyes.

Comment 23

[Matt Thompson (@OpenMatt :OpenMatt)]

* Thank you! You are my JSON Angel :) 

* Looks like the CTAs on these pages are missing?
https://webmaker.mofostaging.net/en-US/resources/literacy/weblit-Navigation
https://webmaker.mofostaging.net/en-US/resources/literacy/weblit-Search
etc.

even though it was in the JSON?

1)  Can you add those?

2) Can we push this from staging to production at earliest opportunity? This is already better than what's currently on production, so might as well push. (As long as that won't break anything else.)

Comment 24

[Aki Rose Braun [:akirose]]

Attachment: https://github.com/mozilla/webmaker.org/pull/815

Comment 25

[Aki Rose Braun [:akirose]]

Just to confirm:
- weblit-Sharing has no CTAs
- weblit-Collaborating has no CTAs
- weblit-Community has no CTAs
- weblit-Privacy CTAs are blank
- weblit-OpenPractices has no CTAs

Comment 26

[inactivate account for kate]

Comment on attachment 8442225 [details] [review]
https://github.com/mozilla/webmaker.org/pull/815

Looks ok to me, but yeah, we confirm those empty ctas

Comment 27

[Matt Thompson (@OpenMatt :OpenMatt)]

Aki: yes, those ones are empty, cuz Brett did QA on those pages and didn't add them

* But that's ok. Let's solve that in another ticket. And push this one now.

Comment 28

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/d16daff39e963c5c86cd42483e2524444209d94c
Bug 1023542 - Review and push updated JSON for resources section

https://github.com/mozilla/webmaker.org/commit/80ced273532e4f739489774ce0c0ecc631bc5bdd
Merge pull request #815 from gesa/1023542/more-json-copy

Bug 1023542 - Review and push updated JSON for resources section