Closed Bug 1023569 Opened 9 years ago Closed 5 years ago

document why _processManifestForIds and registerAppsHandlers set app properties silently

Categories

(Core Graveyard :: DOM: Apps, defect)

Product:
Core Graveyard
Component:
DOM: Apps
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: myk, Unassigned)

Details

Per bug 1019054, comment 6, _processManifestForIds and registerAppsHandlers modify the registry silently, setting the "csp", "role", and "redirects" properties of all apps (_processManifestForIds also sets the "name" property), and it isn't clear why.

https://github.com/mozilla/gecko-dev/blob/56e2c15baff6d2d1b187f2fe40ae6c8bfe544dfe/dom/apps/src/Webapps.jsm#L330-L334
https://github.com/mozilla/gecko-dev/blob/56e2c15baff6d2d1b187f2fe40ae6c8bfe544dfe/dom/apps/src/Webapps.jsm#L954-L959

We should document the reason in a code comment accompanying the lines that make the changes.

Fabrice: can you explain why this code does what it does?
Flags: needinfo?(fabrice)
We do that to set the properties of the preloaded apps correctly, as the gaia build system is not adding them. I thinnk it's better to have them in gecko anyway, but we could refactor a bit to not duplicate this snippet.
Flags: needinfo?(fabrice)
Product: Core → Core Graveyard
Core Graveyard / DOM: Apps is inactive. Closing all bugs in this component.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.